resourceapply: log changes when objects are modified #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
mfojtik
force-pushed
the
add-more-logging
branch
from
78c59de
to
d3bac3f
Compare
mfojtik
force-pushed
the
add-more-logging
branch
from
d3bac3f
to
6153457
Compare
|
/hold will add more changes |
openshift-ci-robot
added
the
do-not-merge/hold
mfojtik
force-pushed
the
add-more-logging
branch
from
6153457
to
5daa68d
Compare
|
/hold cancel Change the status controller to spit json patch diff instead of object diff (it reads better and it is more compact). |
openshift-ci-robot
removed
the
do-not-merge/hold
mfojtik
force-pushed
the
add-more-logging
branch
from
5daa68d
to
fe136da
Compare
mfojtik
force-pushed
the
add-more-logging
branch
from
fe136da
to
65724e8
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, mfojtik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
bertinatto
pushed a commit
to bertinatto/library-go
that referenced
this pull request
Jul 2, 2020
resourceapply: log changes when objects are modified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will cause logging all changes to resources that we apply updates to. We already log diffs with CR's but we don't see why we changing things like pods/role bindings/etc.
I think this will improve our ability to debug changes done by operators and identify changes that are not desired which is worth the extra
DeepCopy()?Test bump: openshift/cluster-kube-controller-manager-operator#160