Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-5.5] LOG-4638: Update golang.org/x/net and Go #199

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

xperimental
Copy link

@xperimental xperimental commented Oct 13, 2023

Backport of grafana#10874 to 5.5

Refs LOG-4638

This needed additional changes for the update to 1.20 to work:

  • Update of golangci-lint
  • Update of go4.org/unsafe/assume-no-moving-gc
  • Source formatting

- Update golangci-lint
- Update assume-no-moving-gc
- Format source
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 13, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 13, 2023

@xperimental: This pull request references LOG-4638 which is a valid jira issue.

In response to this:

Backport of grafana#10874 to 5.5

Refs LOG-4638

This needed additional changes for the update to 1.20 to work:

  • Update of golangci-lint
  • Update of go4.org/unsafe/assume-no-moving-gc
  • Source formatting

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 13, 2023

@xperimental: This pull request references LOG-4638 which is a valid jira issue.

In response to this:

Backport of grafana#10874 to 5.5

Refs LOG-4638

This needed additional changes for the update to 1.20 to work:

  • Update of golangci-lint
  • Update of go4.org/unsafe/assume-no-moving-gc
  • Source formatting

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from jcantrill and shwetaap October 13, 2023 21:09
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2023
@xperimental
Copy link
Author

/retest-required

@openshift-ci
Copy link

openshift-ci bot commented Oct 16, 2023

@xperimental: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@periklis
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: periklis, xperimental

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [periklis,xperimental]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit ce864b1 into openshift:release-5.5 Oct 16, 2023
@xperimental xperimental deleted the http2-cve-5.5 branch October 16, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants