Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-5.7] Backport PR grafana/loki#12503 and grafana/loki#12698 #296

Merged
merged 1 commit into from
May 2, 2024
Merged

[release-5.7] Backport PR grafana/loki#12503 and grafana/loki#12698 #296

merged 1 commit into from
May 2, 2024

Conversation

periklis
Copy link

Backport golang builder bump to 1.21.9 and golang/x/net to 0.23.0 to address:

@periklis periklis self-assigned this Apr 25, 2024
@periklis
Copy link
Author

/hold Pushing this to the next release 5.7.14 as we wait for trackers to be created.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2024
@openshift-ci openshift-ci bot requested review from alanconway and vimalk78 April 25, 2024 19:04
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024
@periklis
Copy link
Author

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 25, 2024

@periklis: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoaoBraveCoding
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoaoBraveCoding, periklis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@periklis periklis mentioned this pull request Apr 28, 2024
Merged
@periklis
Copy link
Author

periklis commented May 2, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 4355090 into openshift:release-5.7 May 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xperimental xperimental Awaiting requested review from xperimental

@JoaoBraveCoding JoaoBraveCoding Awaiting requested review from JoaoBraveCoding

@alanconway alanconway Awaiting requested review from alanconway

@vimalk78 vimalk78 Awaiting requested review from vimalk78

Assignees

@periklis periklis

@JoaoBraveCoding JoaoBraveCoding

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@periklis @JoaoBraveCoding