-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-34227: fix: move checks into readiness and introduce grpc health #658
OCPBUGS-34227: fix: move checks into readiness and introduce grpc health #658
Conversation
@jakobmoellerdev: This pull request references Jira Issue OCPBUGS-34227, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakobmoellerdev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #658 +/- ##
==========================================
+ Coverage 57.91% 58.22% +0.31%
==========================================
Files 53 55 +2
Lines 4215 4285 +70
==========================================
+ Hits 2441 2495 +54
- Misses 1532 1542 +10
- Partials 242 248 +6
|
/override ci/prow/snyk-deps |
@jakobmoellerdev: Overrode contexts on behalf of jakobmoellerdev: ci/prow/snyk-deps In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
/test e2e-aws |
/test e2e-aws |
/test e2e-aws |
d17a209
to
4b87fac
Compare
This avoids the pod shutdown in case of healthiness errors, e.g. when the device class setup takes extremely long. This has the side effect of vgmanager possibly hanging up if there is a hangup in one of its servers, but it will show a not Ready State if that happens. Also now the node server only reports healthiness once this has been successfully completed Signed-off-by: Jakob Möller <jmoller@redhat.com>
4b87fac
to
b9f10bd
Compare
/override ci/prow/snyk-deps |
@jakobmoellerdev: Overrode contexts on behalf of jakobmoellerdev: ci/prow/snyk-deps In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test e2e-aws |
/lgtm |
@jakobmoellerdev: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@jakobmoellerdev: Jira Issue OCPBUGS-34227: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-34227 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This avoids the pod shutdown in case of healthiness errors, e.g. when the device class setup takes extremely long. This has the side effect of vgmanager possibly hanging up if there is a hangup in one of its servers, but it will show a not Ready State if that happens. Also now the node server only reports healthiness once this has been successfully completed.
This concretely fixes a situation in which the lvmd setup takes extremely long due to thinpool provisioning (e.g. 5 mins for zeroing a huge array of disks) and the kubelet would kill the pod due to the failing healthiness.