Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce KubeSAN codepath for shared volume groups #667

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jakobmoellerdev
Copy link
Contributor

@jakobmoellerdev jakobmoellerdev commented Jul 15, 2024

TODO:

  • Setup RBAC for KubeSAN
  • Setup Driver Registration via internal node registration of vgmanager
  • Setup Health Check in vgmanager to use correct driver
  • Allow setting up multiple StorageClasses and drivers based on deviceClasses
  • Allow configuration of sidecar container for the kubeSAN driver
  • Find a easy way to add lvmlockd and sanlock to test clusters before introducing it in OpenShift CoreOS builds - CoreOS layering and a hack script works good enough
  • Integrate the controller of kubesan directly into either vgmanager (unoptimized), lvm-operator (more complex) or as a separate deployment
  • Create a first demo case
  • Run CNV on a cluster with LVMS as base

Optional for POC:

  • Find a sophisticated way to add lvmlockd and sanlock to default os builds OR
  • Find a way to create dynamic machine configurations that patch kubesan into the OS (not preferred)
  • Make Unit & E2E tests run (needs multi attach disk setup for testing)
  • Integrate Controllers for performance optimization
  • Have a smarter ValidNodes detection that can use smart nodeselectors to create 2 daemonsets, one for shared and one for not shared volume groups
  • Refactor the logic paths to not have so much code duplication

Related KubeSAN branch can be found here

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2024
Copy link
Contributor

openshift-ci bot commented Jul 15, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 15, 2024
Copy link
Contributor

openshift-ci bot commented Jul 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2024
Signed-off-by: Jakob Möller <jmoller@redhat.com>
Signed-off-by: Jakob Möller <jmoller@redhat.com>
Signed-off-by: Jakob Möller <jmoller@redhat.com>
Signed-off-by: Jakob Möller <jmoller@redhat.com>
Signed-off-by: Jakob Möller <jmoller@redhat.com>
Signed-off-by: Jakob Möller <jmoller@redhat.com>
Signed-off-by: Jakob Möller <jmoller@redhat.com>
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 23, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants