MIXEDARCH-129: Adds the MergeCommaSeparatedKeyValues method in the util package #1147
Conversation
aleskandro
force-pushed
the
merge-csv-string
branch
from
43fd2ed
to
5bb2565
Compare
In the efforts for MIXEDARCH-129, we will need to change several cloud providers' actuators to get the kubernetes.io/arch label considered for scaling from zero. The upstream changes introduced by kubernetes/autoscaler/pull/5382 allow us to use an annotation to instruct the autoscaler about the node labels. The actuators will consume the method introduced by this commit to merge the comma-separated list of key-value pairs stored in that annotation with any others the actuators want to add.
aleskandro
force-pushed
the
merge-csv-string
branch
from
5bb2565
to
59ec86d
Compare
aleskandro
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@aleskandro: This pull request references MIXEDARCH-129 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@aleskandro: This pull request references MIXEDARCH-129 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test unit |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/label jira/valid-bug |
openshift-ci
bot
added
the
jira/valid-bug
|
@aleskandro: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required |
This commit vendors the machine-api-operator to include the new method from openshift/machine-api-operator#1147 and build the annotations for providing the architecture information to the kubernetes autoscaler.
This commit vendors the machine-api-operator to include the new method from openshift/machine-api-operator#1147 and build the annotations for providing the architecture information to the kubernetes autoscaler.
This commit vendors the machine-api-operator to include the new method from openshift/machine-api-operator#1147 and build the annotations for providing the architecture information to the kubernetes autoscaler.
This commit vendors the machine-api-operator to include the new method from openshift/machine-api-operator#1147 and build the annotations for providing the architecture information to the kubernetes autoscaler.
This commit vendors the machine-api-operator to include the new method from openshift/machine-api-operator#1147 and build the annotations for providing the architecture information to the kubernetes autoscaler.
This commit vendors the machine-api-operator to include the new method from openshift/machine-api-operator#1147 and build the annotations for providing the architecture information to the kubernetes autoscaler.
In the efforts for MIXEDARCH-129, we will need to change several cloud providers' actuators to get the kubernetes.io/arch label considered for scaling from zero. The upstream changes introduced by kubernetes/autoscaler/pull/5382 allow us to use an annotation to instruct the autoscaler about the node labels. The actuators will consume the method introduced by this commit to merge the comma-separated list of key-value pairs stored in that annotation with any others the actuators want to add.
cc @elmiko @JoelSpeed @Prashanth684