Healthchecking #117
Merged
Healthchecking #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enxebre
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
size/XXL
enxebre
added
the
do-not-merge/work-in-progress
enxebre
force-pushed
the
healthchecking
branch
from
5a7825b
to
76712ae
Compare
enxebre
force-pushed
the
healthchecking
branch
from
76712ae
to
7c12b59
Compare
enxebre
removed
the
do-not-merge/work-in-progress
frobware
requested changes
Nov 13, 2018
pkg/controller/machinehealthcheck/machinehealthcheck_controller.go
Outdated
Show resolved
Hide resolved
pkg/controller/machinehealthcheck/machinehealthcheck_controller.go
Outdated
Show resolved
Hide resolved
| return reconcile.Result{}, err | ||
| } | ||
|
|
||
| if machineKey, ok := node.Annotations[machineAnnotationKey]; ok { |
There was a problem hiding this comment.
Reduce the indentation by returning early on !ok.
pkg/controller/machinehealthcheck/machinehealthcheck_controller.go
Outdated
Show resolved
Hide resolved
pkg/controller/machinehealthcheck/machinehealthcheck_controller_test.go
Outdated
Show resolved
Hide resolved
pkg/controller/machinehealthcheck/machinehealthcheck_controller_test.go
Outdated
Show resolved
Hide resolved
pkg/controller/machinehealthcheck/machinehealthcheck_controller_test.go
Outdated
Show resolved
Hide resolved
pkg/controller/machinehealthcheck/machinehealthcheck_controller_test.go
Outdated
Show resolved
Hide resolved
enxebre
force-pushed
the
healthchecking
branch
2 times, most recently
from
1fd5ab5
to
7d96cef
Compare
enxebre
force-pushed
the
healthchecking
branch
from
7d96cef
to
4f25046
Compare
|
/test all |
frobware
approved these changes
Nov 14, 2018
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frobware The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
ingvagabund
pushed a commit
to ingvagabund/machine-api-operator
that referenced
this pull request
Jul 11, 2019
rename test-e2e to unify this target meaning along all repos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- Revendor for operator sdk and so controller runtime
-- Introduce machineHealthChecking API
-- Introduce machineHealthCheck controller for watching nodes and get backing machines belonging to an existing healthcheck
-- Remediation logic