Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openstack: Add the deprecated controller image #193

Closed
wants to merge 1 commit into from
Closed

openstack: Add the deprecated controller image #193

wants to merge 1 commit into from

Conversation

tomassedovic
Copy link
Contributor

The machine-api-operator pod was failing on OpenStack because the
.Controllers.ProviderDeprecated value was set to an empty string.

This makes sure that value is set for OpenStack as well to fix the
actuator coming up.

@tomassedovic
openstack: Add the deprecated controller image
7c819fb 
The `machine-api-operator` pod was failing on OpenStack because the
`.Controllers.ProviderDeprecated` value was set to an empty string.

This makes sure that value is set for OpenStack as well to fix the
actuator coming up.
@tomassedovic
Copy link
Contributor Author

/cc @enxebre

@enxebre
Copy link
Member

enxebre commented Feb 4, 2019 •
edited
Loading

thanks! @tomassedovic I also put #192
#193 means it would break during a small period of time between between when you update the actuator and the installer to rely on the new group machine.openshift.io
#192 means you have a backward compatible path but any new change to your actuator won't take effect until you update the installer to run the machines into the new group
Let me know which way you'd like to proceed

@tomassedovic
Copy link
Contributor Author

@enxebre ah, d'oh! Yeah, I prefer #192, but I'd like to hear what @flaper87 thinks as well.

All of this deprecated stuff will be removed soon anyway, right?

@enxebre
Copy link
Member

enxebre commented Feb 4, 2019 •
edited
Loading

@tomassedovic yes, support for cluster.k8s.io hence the deprecated controllers will be dropped asap. Once this gets openshift/installer#1175 and your analogous PR for Openstack in the installer get merged

@openshift-ci-robot
Copy link
Contributor

@tomassedovic: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/jenkins/integration 7c819fb link /test integration
ci/prow/e2e-aws 7c819fb link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@enxebre
Copy link
Member

enxebre commented Feb 4, 2019

closing in favour of #192

@enxebre enxebre closed this Feb 4, 2019
@tomassedovic tomassedovic deleted the add-openstack-deprecated-image branch February 4, 2019 13:54
ingvagabund pushed a commit to ingvagabund/machine-api-operator that referenced this pull request Jul 11, 2019
@openshift-merge-robot
Merge pull request openshift#193 from paulfantom/owners
fb28510 
Remove myself from OWNERS file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enxebre enxebre Awaiting requested review from enxebre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomassedovic @enxebre @openshift-ci-robot