Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MCC should have MCs Ignition validation #502

Closed
runcom opened this issue Feb 26, 2019 · 2 comments · Fixed by #529
Closed

MCC should have MCs Ignition validation #502

runcom opened this issue Feb 26, 2019 · 2 comments · Fixed by #529
Assignees
@kikisdeliveryservice

Comments

@runcom
Copy link
Member

runcom commented Feb 26, 2019

Taken from: #481 (comment)

We should add ignition validation to the MCC as well (it's gonna be in MCD via #481 )
@kikisdeliveryservice
Copy link
Contributor

On it!

@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Feb 26, 2019 •
edited
Loading

Ok, so for this, I'm going to do #498 first because without an ignition version those mcs will fail any validation that I add.

Merged
2 tasks
@kikisdeliveryservice kikisdeliveryservice mentioned this issue Mar 7, 2019
Merged
kikisdeliveryservice added a commit to kikisdeliveryservice/machine-config-operator that referenced this issue Mar 12, 2019
@kikisdeliveryservice
add ignition version to ssh and registries machineconfigs
4b80c8b 
Currently, ssh and registries machineconfigs do not have ignition
versions. PR ensure that when those configs are generated, version
is not empty (current value = 2.2.0)

Also, created helper function in controller/common NewIgnConfig that
returns an empty ignition config with version 2.2.0.

Closes: openshift#498
Pre-req for: openshift#502
kikisdeliveryservice added a commit to kikisdeliveryservice/machine-config-operator that referenced this issue Mar 15, 2019
@kikisdeliveryservice
mcc: add an ignition validation to render controller
c7ec48f 
Add check to render_controller.go to ensure that all machineconfigs merged
by getRenderedMachineConfig() contain valid ignition configs.

Closes: openshift#502
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kikisdeliveryservice kikisdeliveryservice

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mcc: add ignition validation to render controller kikisdeliveryservice/machine-config-operator
2 participants
@runcom @kikisdeliveryservice