Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update k8s drain lib so we can use stable daemonset API group #71

Closed
jlebon opened this issue Sep 17, 2018 · 3 comments · Fixed by #1571
Closed

Update k8s drain lib so we can use stable daemonset API group #71

jlebon opened this issue Sep 17, 2018 · 3 comments · Fixed by #1571

Comments

@jlebon
Copy link
Member

jlebon commented Sep 17, 2018

See #70 (comment).
@jlebon jlebon mentioned this issue Sep 17, 2018
Merged
@ashcrow
Copy link
Member

ashcrow commented Sep 17, 2018

/kind enhancement

@wking
Copy link
Member

wking commented Sep 20, 2018

Should this be an issue in openshift/kubernetes-drain? And should we get an OWNERS there with some of you on it?

I'd still like to get that library upstreamed into client-go or some such; anything that would help move in that direction is welcome :).

@cgwalters cgwalters mentioned this issue Dec 18, 2018
Closed
@runcom
Copy link
Member

runcom commented May 11, 2019

drain now has its own library in kube upstream, let's move forward to that (kubernetes/kubernetes#72827)

@runcom runcom added the jira label May 11, 2019
@dustymabe dustymabe removed the jira label Sep 5, 2019
@runcom runcom mentioned this issue Mar 18, 2020
Merged
osherdp pushed a commit to osherdp/machine-config-operator that referenced this issue Apr 13, 2021
@openshift-merge-robot
Merge pull request openshift#71 from gabemontero/move-off-operator-sdk
86ea4f7 
move samples operator off of operator sdk; adjust e2e-test so it does…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pkg/daemon: use upstream kubectl/pkg/drain runcom/machine-config-operator
5 participants
@ashcrow @wking @runcom @dustymabe @jlebon