Bug 1763635: pkg/operator: fix race between images CM and MCO #1198
Conversation
Signed-off-by: Antonio Murdaca <runcom@linux.com>
runcom
added
the
do-not-merge/hold
openshift-ci-robot
added
size/XS
|
/retest |
|
/skip |
runcom
changed the title
|
@runcom: This pull request references Bugzilla bug 1763635, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
lifting the hold as there is enough evidence that this is the right approach and fix /hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
| @@ -6,6 +6,7 @@ metadata: | |||
| data: | |||
| images.json: > | |||
| { | |||
| "releaseVersion": "0.0.1-snapshot", | |||
There was a problem hiding this comment.
Is there something that substitutes this value? In oc adm release new? I am not seeing it in $ rg releaseVersion in oc git master.
There was a problem hiding this comment.
oc adm release new is substituting it according to my manual testing, if you can double check that , it would be amazing
There was a problem hiding this comment.
also, grep for 0.0.1-snapshot in openshift/origin - that's where the substitution is
There was a problem hiding this comment.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@runcom: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@runcom: All pull requests linked via external trackers have merged. Bugzilla bug 1763635 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Full context here https://docs.google.com/document/d/1mBDXujKsQjf0SSP9abLE_Mczvc8KE9D8qmeyoGdrD5Y/edit# (will make it public asap)
holding as it needs a proper bugzilla and whole process as well if this is accepted.
Signed-off-by: Antonio Murdaca runcom@linux.com