Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Uncordon the node during failed updates #1572

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pkg/daemon/update.go
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,15 @@ func (dn *Daemon) update(oldConfig, newConfig *mcfgv1.MachineConfig) (retErr err
return err
}

defer func() {
if retErr != nil {
if err := drain.RunCordonOrUncordon(dn.drainer, dn.node, false); err != nil {
retErr = errors.Wrapf(retErr, "error rolling back cordon on the node: %v", err)
return
}
}
}()

// update files on disk that need updating
if err := dn.updateFiles(oldConfig, newConfig); err != nil {
return err
Expand Down