-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1827143: daemon: consider addition of an RT kernel package as update #1691
Conversation
Install additional RT kernel package if any shipped as part of update in machine-os-content Also some code cleanup to simplify RT kernel update logic Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1827143
@sinnykumari: This pull request references Bugzilla bug 1827143, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Not tested yet |
/retest |
@sinnykumari: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/skip |
Looks good, relevant log from one of the m-c-d pod during 4.4 to 4.5 upgrade
/hold cancel |
/cc @cgwalters @runcom |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: runcom, sinnykumari The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sinnykumari: All pull requests linked via external trackers have merged: openshift/machine-config-operator#1691. Bugzilla bug 1827143 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
LGTM, thanks for doing this! The code is definitely better now that we're just reading the parsed rpm-ostree JSON state instead of calling out to the subprocess again. One thing that might make sense as part of coreos/fedora-coreos-tracker#401
or something so that we have an abstraction between "feature name" and "list of RPMs making up feature" - kind of like metapackages I guess. |
do we really want this 😭 I proposed another way of tackling what I think are security options using something like "securityLevels" or profiles. You just set that in an MC and the MCO knows what to install (much like we do with |
Definitely worth discussing a higher level interface! |
Install additional RT kernel package if any shipped
as part of update in machine-os-content
Also some code cleanup to simplify RT kernel update logic