Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Send alert when MCO can't safely apply updated Kubelet CA on nodes in paused pool" #3027

Conversation

DennisPeriquet
Copy link
Contributor

Reverts #2802

payload rejection apparently caused by this PR.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DennisPeriquet
To complete the pull request process, please assign cgwalters after the PR has been reviewed.
You can assign the PR to them by writing /assign @cgwalters in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k deads2k merged commit b80e6a1 into openshift:master Mar 17, 2022
@deads2k
Copy link
Contributor

deads2k commented Mar 17, 2022

This is a clean revert of the last merged PR in the repo. This will free up our payloads. Merging so we'll get the next nightly and CI build functional again.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2022

@DennisPeriquet: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jkyros added a commit to jkyros/machine-config-operator that referenced this pull request Mar 17, 2022
…2802-mco-74-controller-alert-certificate"

This reverts commit b80e6a1, reversing
changes made to 57267b7.

This "un-reverts" the reversion so we can put PR 2802 back in with the
fix to resourcemerge.
wking added a commit to wking/openshift-release that referenced this pull request Mar 17, 2022
… conformance for agnostic update jobs

To catch things like [1,2]:

  : [sig-arch] Managed cluster should set requests but not limits [Suite:openshift/conformance/parallel] expand_less
  Run #0: Failed expand_less	5s
    {  fail [github.com/onsi/ginkgo@v4.7.0-origin.0+incompatible/internal/leafnodes/runner.go:113]: Mar 17 07:42:21.144: Pods in platform namespaces are not following resource request/limit rules or do not have an exception granted:
       apps/v1/Deployment/openshift-machine-config-operator/machine-config-controller/container/oauth-proxy does not have a cpu request (rule: "apps/v1/Deployment/openshift-machine-config-operator/machine-config-controller/container/oauth-proxy/request[cpu]")
       apps/v1/Deployment/openshift-machine-config-operator/machine-config-controller/container/oauth-proxy does not have a memory request (rule: "apps/v1/Deployment/openshift-machine-config-operator/machine-config-controller/container/oauth-proxy/request[memory]")}

before they merge and break release acceptance.

[1]: openshift/machine-config-operator#3027
[2]: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-ci-4.11-upgrade-from-stable-4.10-e2e-azure-upgrade/1504329125391765504
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants