Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Ignition file generation to controller/common, fix Compression #3128

Commits on May 2, 2022

  1. Move Ignition file generation to controller/common, fix Compression

    See coreos/butane#332 (comment)
    
    Basically, everywhere we make a "raw" Ignition file type, we need
    to be explicitly setting the compression field.  This is prep
    for updating butane and using it for some of our templates, which
    will start compressing files automatically.
    
    The problem is Ignition config merging is a bit broken with respect
    to an unset compression field.  We need to make it the explicit
    empty string.
    
    Now, when I was digging into this I noticed that we'd ended up with
    our API to make Ignition files in the `test/helpers`.  We shouldn't
    have *core* code importing APIs from `test/`.
    
    This moves the APIs into `controller/common`.
    
    Port the kubelet config and container runtime config bits to this -
    notice how much the code shrinks!
    cgwalters committed May 2, 2022
    Configuration menu
    Copy the full SHA
    da5184f View commit details
    Browse the repository at this point in the history