feat: support generating cpu partitioning file from infra flag

[eggfoobar]

/hold
Needs PR: openshift/api#1284
EP: openshift/enhancement#1213

Signed-off-by: ehila ehila@redhat.com

- What I did

Add support for generating a machine config file that will configure kubelet for workload partitioning based off of the infrastructure flag.

- How to verify it
When the Infrastructure status resource is set to cpuPartitioning: AllNodes, we will generate two new MCs for workload partitioning named 01-master-cpu-partitioning and 01-worker-cpu-partitioning that will create a configuration file for kubelet to use on start up.

apiVersion: config.openshift.io/v1
kind: Infrastructure
metadata:
  name: cluster
status:
  cpuPartitioning: AllNodes

- Description for the changelog

Add new generated MCs for workload partitioning based off of infrastructure status.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eggfoobar
Once this PR has been reviewed and has the lgtm label, please assign sinnykumari for approval by writing /assign @sinnykumari in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cgwalters]

There's prior art for the installer generating MachineConfigs based on the install config, see e.g. https://github.com/openshift/installer/blob/master/pkg/asset/machines/machineconfig/hyperthreading.go

I personally don't have a strong opinion on this, but I would say that it makes sense to have the "install time configuration to MachineConfiguration" logic live mainly in one place, whether that's github.com/openshift/installer or here.

[yuqi-zhang]

Discussed on slack, but to clarify, if this only applies to bootstrap, if the MC does get generated, the install will fail due to a mismatch of configs generated by bootstrap and regular, causing a "can't find rendered-master-xxx" when the install happens. Basically #2114

[eggfoobar]

Hey @yuqi-zhang , was looking through the code a bit, trying to understand this a little better. Does this mean that it's not possible to have a MC generated and maintain by MCO during bootstrap?

[yuqi-zhang]

No, it is possible. You must have both the bootstrap and the "in-cluster" flow generate the same configs.

As an example, see this: #3015

which adds both for nodes.config.openshift.io objects

[openshift-ci]

@eggfoobar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-op	0bd1a77	link	true	/test e2e-gcp-op
ci/prow/unit	0bd1a77	link	true	/test unit
ci/prow/e2e-aws	0bd1a77	link	true	/test e2e-aws
ci/prow/e2e-agnostic-upgrade	0bd1a77	link	true	/test e2e-agnostic-upgrade
ci/prow/bootstrap-unit	0bd1a77	link	false	/test bootstrap-unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[eggfoobar]

Thanks folks, appreciate the feedback, I'll close this PR for now.

[eggfoobar]

/reopen

Re-opening this PR, after some discussion with the installer team, MCO seems to be the best place to enforce the CPU Partitioning configuration cluster wide.

[openshift-ci]

@eggfoobar: Failed to re-open PR: state cannot be changed. The cpu_partitioning_bootstrap branch was force-pushed or recreated.

In response to this:

/reopen

Re-opening this PR, after some discussion with the installer team, MCO seems to be the best place to enforce the CPU Partitioning configuration cluster wide.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[eggfoobar]

New PR #3355