Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.13] OCPBUGS-8703: daemon: Only switchkernel if we are doing an OS update or kernel change #3602

Closed
wants to merge 1 commit into from
Closed

[release-4.13] OCPBUGS-8703: daemon: Only switchkernel if we are doing an OS update or kernel change #3602

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #3600

/assign cgwalters

@cgwalters
daemon: Only switchkernel if we are doing an OS update or kernel change
1ad6b74 
This fixes a regression with the previous commit
openshift@8ac5bee
where we would simply fail to roll out on RT node systems any further MachineConfig
changes.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 9, 2023
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-8113 with correct target version. Will retitle the PR to link to the clone.
/retitle [release-4.13] OCPBUGS-8703: daemon: Only switchkernel if we are doing an OS update or kernel change

In response to this:

This is an automated cherry-pick of #3600

/assign cgwalters

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.13] OCPBUGS-8113: daemon: Only switchkernel if we are doing an OS update or kernel change [release-4.13] OCPBUGS-8703: daemon: Only switchkernel if we are doing an OS update or kernel change Mar 9, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 9, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-8703, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #3600

/assign cgwalters

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 9, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.13] OCPBUGS-8703: daemon: Only switchkernel if we are doing an OS update or kernel change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from cgwalters and jkyros March 9, 2023 23:36
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 9, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign sinnykumari for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cgwalters cgwalters mentioned this pull request Mar 10, 2023
Merged
@rioliu-rh
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 10, 2023
@cgwalters
Copy link
Member

Closing in favor of #3604

@cgwalters cgwalters closed this Mar 10, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-8703. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #3600

/assign cgwalters

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 10, 2023

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-rt-op 1ad6b74 link false /test e2e-gcp-rt-op
ci/prow/e2e-hypershift 1ad6b74 link false /test e2e-hypershift
ci/prow/okd-scos-e2e-gcp-ovn-upgrade 1ad6b74 link false /test okd-scos-e2e-gcp-ovn-upgrade
ci/prow/e2e-alibabacloud-ovn 1ad6b74 link false /test e2e-alibabacloud-ovn
ci/prow/okd-scos-e2e-vsphere-ovn 1ad6b74 link false /test okd-scos-e2e-vsphere-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sinnykumari
Copy link
Contributor

Lol, even bot confused and did cherry-pick in wrong function or a bug in git cherry-pick?

sinnykumari added a commit to cgwalters/machine-config-operator that referenced this pull request Mar 10, 2023
@sinnykumari
daemon: Only switchkernel if we are doing an OS update or kernel change
8d66006 
Manual fix since automatic cherry-pick applied to legacy code.
See openshift#3602
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgwalters cgwalters Awaiting requested review from cgwalters

@jkyros jkyros Awaiting requested review from jkyros

Assignees

@cgwalters cgwalters

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@openshift-cherrypick-robot @openshift-ci-robot @rioliu-rh @cgwalters @sinnykumari