-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPCLOUD-2465: Updates GCR CredentialProviderConfig #4260
OCPCLOUD-2465: Updates GCR CredentialProviderConfig #4260
Conversation
@theobarberbany: This pull request references OCPCLOUD-2465 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
matchImages: | ||
- "gcr.io" | ||
- "*.gcr.io" | ||
- "*.pkg.dev" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note this is the Google artifact registry, which is a new version of GCR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This change updates the GCR CredentialProviderConfig to pass the 'get-credentials' argument. It also adds a matcher for "*.pkg.dev"
1d094ea
to
55cee2c
Compare
^ Just a rebase to see if CI is fixed |
Looks to be build cluster issues |
/retest |
CI looking a lot healthier now |
@theobarberbany: This pull request references OCPCLOUD-2465 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, theobarberbany, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/check-required-labels |
/label acknowledge-critical-fixes-only |
d9ffefd
into
openshift:master
@theobarberbany: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-machine-config-operator-container-v4.16.0-202403181742.p0.gd9ffefd.assembly.stream.el8 for distgit ose-machine-config-operator. |
- What I did
This change updates the GCR CredentialProviderConfig to pass the 'get-credentials' argument, which is required for the credential plugin to function correctly.
It also adds a matcher for "*.pkg.dev"
- How to verify it
DisableKubeletCloudCredentialProviders
feature flag- Description for the changelog
Updates GCR CredentialProviderConfig, passing 'get-credentials' and updating matchers