discover MCOConfig from InstallConfig #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is requires so that go test ./... doesn't fail for pkg/operator/... as it imports the pkg/version which is not only correctly setup on build.
this currently reads the kube-system/cluster-config-v1 config map and extracts the installconfig from 'install-config' key. the bootstrap mco reads the cluster-config-v1 config map from disk the long running mco pulls kube-system/cluster-config-v1 from api the long running mco discovers the mcoconfig when it cannot find the mcoconfig from api. if mcoconfig exists at the location in api, it always uses that. mco doesn't create the discovered mcoconfig in cluster as it is mostly discovered fields that user shouldn't be changing.
openshift-ci-robot
added
approved
yifan-gu
reviewed
Sep 7, 2018
| func platformFromInstallConfig(ic installertypes.InstallConfig) string { | ||
| switch { | ||
| case ic.Platform.AWS != nil: | ||
| return "aws" |
There was a problem hiding this comment.
nit: maybe make this const, but it's fine to leave as is
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, yifan-gu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
osherdp
pushed a commit
to osherdp/machine-config-operator
that referenced
this pull request
Apr 13, 2021
use pull policy always
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires openshift/installer#205
this currently reads the kube-system/cluster-config-v1 config map and extracts the installconfig from 'install-config' key.
the bootstrap mco reads the cluster-config-v1 config map from disk, while the long running mco pulls kube-system/cluster-config-v1 from api
the long running mco discovers the mcoconfig when it cannot find the mcoconfig from api. And if mcoconfig exists at the location in api, it always uses that.
mco doesn't create the discovered mcoconfig in cluster as it is mostly discovered fields that user shouldn't be changing directly.
/cc @yifan-gu
/assign @yifan-gu