Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/daemon: add more info to errs #484

Merged
merged 1 commit into from
Mar 1, 2019

Conversation

runcom
Copy link
Member

@runcom runcom commented Feb 23, 2019

Signed-off-by: Antonio Murdaca runcom@linux.com

- What I did

Was in the middle of an issue with my code and the reference erroring out wasn't provided, adding it to ease debugging (and my life)

- How to verify it

- Description for the changelog

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 23, 2019
Signed-off-by: Antonio Murdaca <runcom@linux.com>
@LorbusChris
Copy link
Member

/retest

@jlebon
Copy link
Member

jlebon commented Feb 25, 2019

/approve

@LorbusChris
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlebon, LorbusChris, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [LorbusChris,jlebon,runcom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LorbusChris
Copy link
Member

/test e2e-aws

@openshift-merge-robot openshift-merge-robot merged commit fdf41be into openshift:master Mar 1, 2019
@runcom runcom deleted the wrapferr branch March 1, 2019 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants