Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install: use origin-v4.0 etcd image #511

Merged
merged 1 commit into from
Mar 1, 2019
Merged

install: use origin-v4.0 etcd image #511

merged 1 commit into from
Mar 1, 2019

Conversation

hexfusion
Copy link
Contributor

We are currently using upstream etcd image which is based on Alpine Linux OS. This PR updates this to the correct origin-v4.0 etcd image build.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1679834

/cc @abhinavdahiya

@hexfusion
install: use openshift etcd image
1f2d50b 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 28, 2019
@kikisdeliveryservice
Copy link
Contributor

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2019
@kikisdeliveryservice
Copy link
Contributor

install/image-references change overlaps with the change being made in #508
cc: @cgwalters

@kikisdeliveryservice kikisdeliveryservice requested review from abhinavdahiya and removed request for abhinavdahiya February 28, 2019 21:22
@cgwalters
Copy link
Member

install/image-references change overlaps with the change being made in #50

They're separate images though the patches probably will conflict "textually".

@kikisdeliveryservice
Copy link
Contributor

thanks @cgwalters !

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2019
@kikisdeliveryservice
Copy link
Contributor

/test e2e-aws

@cgwalters
Copy link
Member

/approve

Just want to double check this is a 4.0 target, but I'm pretty sure it should be.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2019
@derekwaynecarr
Copy link
Member

this must be a 4.0 change.

@cgwalters
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, hexfusion

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cgwalters cgwalters added the 4.0 label Mar 1, 2019
@openshift-merge-robot openshift-merge-robot merged commit 806113d into openshift:master Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgwalters cgwalters Awaiting requested review from cgwalters

@runcom runcom Awaiting requested review from runcom

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

Assignees

@cgwalters cgwalters

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hexfusion @kikisdeliveryservice @cgwalters @derekwaynecarr @openshift-ci-robot @openshift-merge-robot