Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USHIFT-2912: Use MicroShift-specific Multus images #3359

Merged
merged 1 commit into from
May 16, 2024
Merged

USHIFT-2912: Use MicroShift-specific Multus images #3359

merged 1 commit into from
May 16, 2024

Conversation

pmtk
Copy link
Member

@pmtk pmtk commented May 15, 2024

Which issue(s) this PR addresses:

Closes #

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 15, 2024
@openshift-ci openshift-ci bot requested review from copejon and pacevedom May 15, 2024 06:05
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2024
@pmtk pmtk force-pushed the multus/microshift-specific-images branch from 7dea581 to ea491ef Compare May 15, 2024 09:22
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2024
@pmtk pmtk changed the title WIP Use MicroShift-specific Multus and CNP images USHIFT-2912: Use MicroShift-specific Multus and CNP images May 15, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 15, 2024 •
edited by openshift-ci bot
Loading

@pmtk: This pull request references USHIFT-2912 which is a valid jira issue.

In response to this:

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 15, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 15, 2024
@pmtk pmtk changed the title USHIFT-2912: Use MicroShift-specific Multus and CNP images USHIFT-2912: Use MicroShift-specific Multus images May 15, 2024
@pmtk
Copy link
Member Author

pmtk commented May 15, 2024

/test ?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 15, 2024

@pmtk: The following commands are available to trigger required jobs:

  • /test images
  • /test metal-bootc-test
  • /test metal-bootc-test-arm
  • /test metal-periodic-test
  • /test metal-periodic-test-arm
  • /test microshift-metal-cache
  • /test microshift-metal-cache-arm
  • /test microshift-metal-tests
  • /test microshift-metal-tests-arm
  • /test ocp-conformance-rhel-eus
  • /test ocp-conformance-rhel-eus-arm
  • /test test-rpm
  • /test test-unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test test-rebase

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-microshift-main-images
  • pull-ci-openshift-microshift-main-microshift-metal-tests
  • pull-ci-openshift-microshift-main-microshift-metal-tests-arm
  • pull-ci-openshift-microshift-main-ocp-conformance-rhel-eus
  • pull-ci-openshift-microshift-main-ocp-conformance-rhel-eus-arm
  • pull-ci-openshift-microshift-main-test-rebase
  • pull-ci-openshift-microshift-main-test-unit
  • pull-ci-openshift-microshift-main-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pmtk
Copy link
Member Author

pmtk commented May 15, 2024

/test metal-periodic-test metal-periodic-test-arm

@pmtk pmtk force-pushed the multus/microshift-specific-images branch from ea491ef to 631987b Compare May 16, 2024 10:25
@pmtk
Copy link
Member Author

pmtk commented May 16, 2024

/test metal-periodic-test metal-periodic-test-arm

@pmtk
Copy link
Member Author

pmtk commented May 16, 2024

/test metal-periodic-test-arm

@pmtk
Copy link
Member Author

pmtk commented May 16, 2024

/test ocp-conformance-rhel-eus-arm

pacevedom
pacevedom approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacevedom, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3ad218c and 2 for PR HEAD 631987b in total

@pacevedom
Copy link
Contributor

/test metal-periodic-test
/test metal-periodic-test-arm

@pmtk
Copy link
Member Author

pmtk commented May 16, 2024

/test metal-periodic-test-arm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 16, 2024

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit eb9269c into openshift:main May 16, 2024
11 checks passed
@pmtk pmtk deleted the multus/microshift-specific-images branch May 17, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacevedom pacevedom pacevedom approved these changes

@copejon copejon Awaiting requested review from copejon

Assignees

@pacevedom pacevedom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pmtk @openshift-ci-robot @pacevedom @openshift-merge-robot