USHIFT-3136: Retry virt-install command in case of installation error #3448
Conversation
|
@ggiguash: This pull request references USHIFT-3136 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
@ggiguash: This pull request references USHIFT-3136 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
|
/test microshift-metal-tests |
ggiguash
force-pushed
the
virt_install_retries
branch
4 times, most recently
from
0b61bdb to
2d9dbeb
Compare
ggiguash
force-pushed
the
virt_install_retries
branch
from
2d9dbeb to
701fb72
Compare
|
/test metal-bootc-test metal-bootc-test-arm metal-periodic-test-arm |
|
/test metal-bootc-test metal-bootc-test-arm metal-periodic-test-arm |
|
Need to find a case when VM creation fails to make sure the new logic works OK. |
|
Found a failed VM here. The code needs to be fixed. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Need to find a case when VM creation fails to make sure the new logic works OK. |
|
Still needs a fix, see this log. |
ggiguash
force-pushed
the
virt_install_retries
branch
from
3fa18f2 to
fda51e8
Compare
|
Need to find a case when VM creation fails to make sure the new logic works OK. |
3 similar comments
|
Need to find a case when VM creation fails to make sure the new logic works OK. |
|
Need to find a case when VM creation fails to make sure the new logic works OK. |
|
Need to find a case when VM creation fails to make sure the new logic works OK. |
|
The retry seems to be working as intended. See this log as an example. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/test metal-periodic-test |
|
@ggiguash: This pull request references USHIFT-3136 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test ocp-full-conformance-rhel-eus |
1 similar comment
|
/test ocp-full-conformance-rhel-eus |
|
The failures in this job are not related to the changes. Saving CI cycles. |
|
@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/ocp-full-conformance-rhel-eus In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: copejon, ggiguash The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-4.16 |
|
@ggiguash: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test metal-periodic-test |
|
/hold Revision fda51e8 was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
The VM startup works as expected. The tests fail due to FIPS problems unrelated to this PR. Overriding to save CI cycles. |
|
@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/metal-periodic-test In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@ggiguash: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@ggiguash: new pull request created: #3482 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This change should provide a workaround for VM installation problems like ostree pull timeouts (USHIFT-3136), stuck ARM VM on reboot (USHIFT-3152), etc.
See this log as an example of a retry.