Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USHIFT-3733: add management annotation to topolvm pods #3591

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

eslutsky
Copy link
Contributor

@eslutsky eslutsky commented Jul 5, 2024

topolvm pods are the only who missing the target.workload.openshift.io/management annotation:

oc get pods -o jsonpath='{range .items[*]}{.metadata.name}{" -- "}{.metadata.annotations.target\.workload\.openshift\.io/management}{"\n"}{end}' -A
csi-snapshot-controller-75d4fbc9df-c7cpz -- {"effect":"PreferredDuringScheduling"}
csi-snapshot-webhook-8547f88946-ktj89 -- {"effect":"PreferredDuringScheduling"}
dns-default-grvvs -- {"effect": "Preferredoc get pods -o jsonpath='{range .items[*]}{.metadata.name}{" -- "}{.metadata.annotations.target\.workload\.openshift\.io/management}{"\n"}{end}' -A
csi-snapshot-controller-75d4fbc9df-c7cpz -- {"effect":"PreferredDuringScheduling"}
csi-snapshot-webhook-8547f88946-ktjoc get pods -o jsonpath='{range .items[*]}{.metadata.name}{" -- "}{.metadata.annotations.target\.workload\.openshift\.io/management}{"\n"}{end}' -A
csi-snapshot-controller-75d4fbc9df-c7cpz -- {"effect":"PreferredDuringScheduling"}
csi-snapshot-webhook-8547f88946-ktj89 -- {"effect":"PreferredDuringScheduling"}
dns-default-grvvs -- {"effect": "PreferredDuringScheduling"}
node-resolver-6vqsl -- {"effect": "PreferredDuringScheduling"}
router-default-c8f9c658f-bmjxr -- {"effect":"PreferredDuringScheduling"}
ovnkube-master-vmgfn -- {"effect": "PreferredDuringScheduling"}
ovnkube-node-hx9gn -- {"effect": "PreferredDuringScheduling"}
service-ca-66779bb75c-k7n7m -- {"effect": "PreferredDuringScheduling"}
topolvm-controller-8497cc4b9c-b5srf --
topolvm-node-jlfpv -- 89 -- {"effect":"PreferredDuringScheduling"}
dns-default-grvvs -- {"effect": "PreferredDuringScheduling"}
node-resolver-6vqsl -- {"effect": "PreferredDuringScheduling"}
router-default-c8f9c658f-bmjxr -- {"effect":"PreferredDuringScheduling"}
ovnkube-master-vmgfn -- {"effect": "PreferredDuringScheduling"}
ovnkube-node-hx9gn -- {"effect": "PreferredDuringScheduling"}
service-ca-66779bb75c-k7n7m -- {"effect": "PreferredDuringScheduling"}
topolvm-controller-8497cc4b9c-b5srf --
topolvm-node-jlfpv -- DuringScheduling"}
node-resolver-6vqsl -- {"effect": "PreferredDuringScheduling"}
router-default-c8f9c658f-bmjxr -- {"effect":"PreferredDuringScheduling"}
ovnkube-master-vmgfn -- {"effect": "PreferredDuringScheduling"}
ovnkube-node-hx9gn -- {"effect": "PreferredDuringScheduling"}
service-ca-66779bb75c-k7n7m -- {"effect": "PreferredDuringScheduling"}
topolvm-controller-8497cc4b9c-b5srf --
topolvm-node-jlfpv --

Signed-off-by: Evgeny Slutsky <eslutsky@redhat.com>
@openshift-ci openshift-ci bot requested review from copejon and ggiguash July 5, 2024 10:15
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2024
Copy link
Contributor

@jakobmoellerdev jakobmoellerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on LVMS side, this has been forgotten in the microshift components

@eslutsky eslutsky changed the title add management annotation to topolvm pods USHIFT-3733: add management annotation to topolvm pods Jul 5, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 5, 2024

@eslutsky: This pull request references USHIFT-3733 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to this:

topolvm pods are the only who missing the target.workload.openshift.io/management annotation:

oc get pods -o jsonpath='{range .items[*]}{.metadata.name}{" -- "}{.metadata.annotations.target\.workload\.openshift\.io/management}{"\n"}{end}' -A
csi-snapshot-controller-75d4fbc9df-c7cpz -- {"effect":"PreferredDuringScheduling"}
csi-snapshot-webhook-8547f88946-ktj89 -- {"effect":"PreferredDuringScheduling"}
dns-default-grvvs -- {"effect": "Preferredoc get pods -o jsonpath='{range .items[*]}{.metadata.name}{" -- "}{.metadata.annotations.target\.workload\.openshift\.io/management}{"\n"}{end}' -A
csi-snapshot-controller-75d4fbc9df-c7cpz -- {"effect":"PreferredDuringScheduling"}
csi-snapshot-webhook-8547f88946-ktjoc get pods -o jsonpath='{range .items[*]}{.metadata.name}{" -- "}{.metadata.annotations.target\.workload\.openshift\.io/management}{"\n"}{end}' -A
csi-snapshot-controller-75d4fbc9df-c7cpz -- {"effect":"PreferredDuringScheduling"}
csi-snapshot-webhook-8547f88946-ktj89 -- {"effect":"PreferredDuringScheduling"}
dns-default-grvvs -- {"effect": "PreferredDuringScheduling"}
node-resolver-6vqsl -- {"effect": "PreferredDuringScheduling"}
router-default-c8f9c658f-bmjxr -- {"effect":"PreferredDuringScheduling"}
ovnkube-master-vmgfn -- {"effect": "PreferredDuringScheduling"}
ovnkube-node-hx9gn -- {"effect": "PreferredDuringScheduling"}
service-ca-66779bb75c-k7n7m -- {"effect": "PreferredDuringScheduling"}
topolvm-controller-8497cc4b9c-b5srf --
topolvm-node-jlfpv -- 89 -- {"effect":"PreferredDuringScheduling"}
dns-default-grvvs -- {"effect": "PreferredDuringScheduling"}
node-resolver-6vqsl -- {"effect": "PreferredDuringScheduling"}
router-default-c8f9c658f-bmjxr -- {"effect":"PreferredDuringScheduling"}
ovnkube-master-vmgfn -- {"effect": "PreferredDuringScheduling"}
ovnkube-node-hx9gn -- {"effect": "PreferredDuringScheduling"}
service-ca-66779bb75c-k7n7m -- {"effect": "PreferredDuringScheduling"}
topolvm-controller-8497cc4b9c-b5srf --
topolvm-node-jlfpv -- DuringScheduling"}
node-resolver-6vqsl -- {"effect": "PreferredDuringScheduling"}
router-default-c8f9c658f-bmjxr -- {"effect":"PreferredDuringScheduling"}
ovnkube-master-vmgfn -- {"effect": "PreferredDuringScheduling"}
ovnkube-node-hx9gn -- {"effect": "PreferredDuringScheduling"}
service-ca-66779bb75c-k7n7m -- {"effect": "PreferredDuringScheduling"}
topolvm-controller-8497cc4b9c-b5srf --
topolvm-node-jlfpv --

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 5, 2024
@eslutsky
Copy link
Contributor Author

eslutsky commented Jul 5, 2024

/retest

@copejon
Copy link
Contributor

copejon commented Jul 8, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2024
Copy link
Contributor

openshift-ci bot commented Jul 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: copejon, eslutsky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jul 8, 2024

@eslutsky: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b971846 into openshift:main Jul 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants