USHIFT-3476: Test harness ipv6 adaptations #3635
Conversation
|
@pacevedom: This pull request references USHIFT-3476 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
approved
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/test microshift-metal-tests-arm |
|
/test metal-periodic-test-arm |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/test metal-periodic-test-arm |
| if [ "${ip}" != "${ip#*:[0-9a-fA-F]}" ]; then | ||
| ip="[${ip}]" | ||
| fi | ||
| local -r ssh_port=$(get_vm_property "${vmname}" ssh_port) |
There was a problem hiding this comment.
It's probably not likely to fail, but it'd be good to follow the same pattern used for ip to make sure the exit status of the subproc is caught.
There was a problem hiding this comment.
Created https://issues.redhat.com/browse/USHIFT-3769 for this purpose. Thanks!
|
It looks good. A minor nit, but not a blocker. I'll label and hold incase you want to fix it, else feel free to drop the hold /lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: copejon, pacevedom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/test metal-periodic-test-arm |
|
@pacevedom: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Which issue(s) this PR addresses:
Closes #