USHIFT-5099: SOS report support for offline VMs #4575
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@vanhalenar: This pull request references USHIFT-5099 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vanhalenar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| "${ROOTDIR}/_output/robotenv/bin/python" "${ROOTDIR}/test/resources/qemu-guest-agent.py" "$@" | ||
| } | ||
|
|
||
| wait_for_qemu_agent() { |
There was a problem hiding this comment.
How does this differ from guest_agent_is_ready from py file? Is the problem that it doesn't return a value?
There was a problem hiding this comment.
yes, and also it uses the _execute function, which does not let you add params to the virsh command, and I wanted to use the --timeout 2 param there
There was a problem hiding this comment.
I felt it was better to just print a message if the agent is not yet ready because it's expected to not be ready right away, instead of raising errors
| cp_from_parser.add_argument("--vm", required=True, help="domain name") | ||
| cp_from_parser.add_argument("--src_dir", required=True, help="source path on VM") | ||
| cp_from_parser.add_argument("--dst_dir", required=True, help="local destination path") | ||
| cp_from_parser.add_argument("--pat", required=True, help="filename or pattern") |
There was a problem hiding this comment.
Not sure about --pat but no ideas for replacement
There was a problem hiding this comment.
yeah I don't like it much either, but I didn't have a better idea, should I just leave it --pat then?
|
@vanhalenar: The specified target(s) for The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-aws-tests-bootc-periodic-arm |
|
@vanhalenar: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.