-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adding go.mod replace statements and use imports instead of copied code #1341
Comments
adding this PR for future insights about how to fix the problem https://github.com/shubham-pampattiwar/oadp-operator/pull/1/files |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
@openshift-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There are several functions that were copied into this repo from other repos for reasons such as
We want to eliminate functions that could be imported even if it means adding replace statements provided
Instances of package containing function imports incompatible go.mod dependency
func GetBucketRegion(bucket string)
from openshift-velero-pluginfunc LeaderElectionDefaulting(config configv1.LeaderElection, defaultNamespace, defaultName string) configv1.LeaderElection
from openshift/library-goprivate functions/structs copied code
Priority: eliminate team's own repos copied code first. Ideally source repo would also import the same k8s deps the same version velero uses so replace statements are more avoidable.
The text was updated successfully, but these errors were encountered: