Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding go.mod replace statements and use imports instead of copied code #1341

Closed
3 tasks
kaovilai opened this issue Feb 21, 2024 · 5 comments
Closed
3 tasks
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@kaovilai
Copy link
Member

kaovilai commented Feb 21, 2024

There are several functions that were copied into this repo from other repos for reasons such as

  • private functions
  • package containing function imports incompatible go.mod dependency that would have required go.mod replace statements to remedy

We want to eliminate functions that could be imported even if it means adding replace statements provided

  • the replace uses version openshift/velero uses.
  • it does not create cyclic import at the package level (go should prevent this anyway)

Instances of package containing function imports incompatible go.mod dependency

private functions/structs copied code

  • velero server args

Priority: eliminate team's own repos copied code first. Ideally source repo would also import the same k8s deps the same version velero uses so replace statements are more avoidable.

@mateusoliveira43
Copy link
Contributor

mateusoliveira43 commented Feb 21, 2024

adding this PR for future insights about how to fix the problem https://github.com/shubham-pampattiwar/oadp-operator/pull/1/files

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 22, 2024
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 21, 2024
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this as completed Jul 22, 2024
Copy link

openshift-ci bot commented Jul 22, 2024

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants