Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update layout to go.kubebuilder.io/v3 layout. make bundle, and update bundle manifests, remove /deploy #395

Merged
merged 3 commits into from
Nov 15, 2021
Merged

update layout to go.kubebuilder.io/v3 layout. make bundle, and update bundle manifests, remove /deploy #395

merged 3 commits into from
Nov 15, 2021

Conversation

kaovilai
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2021 •
edited
Loading

Codecov Report

Merging #395 (35d8ffc) into master (7f01111) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #395   +/-   ##
=======================================
  Coverage   41.48%   41.48%           
=======================================
  Files           9        9           
  Lines        1849     1849           
=======================================
  Hits          767      767           
  Misses       1033     1033           
  Partials       49       49

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0d4b18...35d8ffc. Read the comment docs.

@kaovilai kaovilai changed the title fix make bundle, and update bundle manifests, remove /deploy update layout to go.kubebuilder.io/v3 layout from v1 fix make bundle, and update bundle manifests, remove /deploy Oct 13, 2021
@kaovilai kaovilai changed the title update layout to go.kubebuilder.io/v3 layout from v1 fix make bundle, and update bundle manifests, remove /deploy update layout to go.kubebuilder.io/v3 layout. make bundle, and update bundle manifests, remove /deploy Oct 13, 2021
@kaovilai kaovilai force-pushed the operator-cli_init_PROJECT branch 2 times, most recently from 3a02996 to 0df3337 Compare October 13, 2021 14:23
@kaovilai kaovilai marked this pull request as draft October 13, 2021 14:25
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 13, 2021
@kaovilai
Copy link
Member Author

/test all

@kaovilai kaovilai marked this pull request as ready for review October 13, 2021 14:48
@openshift-ci openshift-ci bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 13, 2021
@dymurray
Copy link
Member

dymurray commented Nov 3, 2021

@kaovilai I would like to get this PR in after we cut 0.4.1. Would you mind rebasing this?

@openshift-ci openshift-ci bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 4, 2021
@kaovilai
Copy link
Member Author

/test operator-e2e

@dymurray
Copy link
Member

/retest

1 similar comment
@dymurray
Copy link
Member

/retest

@openshift-ci
Copy link

openshift-ci bot commented Nov 15, 2021

@kaovilai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/operator-e2e 1281821 link true /test operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dymurray
Copy link
Member

Merging because CI is broken

@dymurray dymurray merged commit 9572f7f into openshift:master Nov 15, 2021
dymurray added a commit that referenced this pull request Nov 17, 2021
@dymurray
Revert "update layout to go.kubebuilder.io/v3 layout. make bundle…
310cba0 
…, and update bundle manifests, remove /deploy (#395)"

This reverts commit 9572f7f.
@dymurray dymurray mentioned this pull request Nov 17, 2021
Merged
dymurray added a commit that referenced this pull request Nov 17, 2021
@dymurray
Revert "update layout to go.kubebuilder.io/v3 layout. make bundle…
16f7a20 
…, and update bundle manifests, remove /deploy (#395)" (#457)

This reverts commit 9572f7f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dymurray dymurray dymurray approved these changes

@alaypatel07 alaypatel07 Awaiting requested review from alaypatel07

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaovilai @codecov-commenter @dymurray