Enable ingestion of the exposed metrics by openshift-montoring

[shubham-pampattiwar]

This PR enable the ingestion of the velero metrics by openshift monitoring. We are deploying the service and serviceMonitor required for the metrics to be scraped by prometheus. We propose the following metrics for the monitoring and telemetry purposes:

"velero_backup_total"
"velero_restore_total"

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[codecov-commenter]

Codecov Report

Merging #410 (c99f511) into master (c1c6b2d) will increase coverage by 0.60%.
The diff coverage is 43.00%.

@@            Coverage Diff             @@
##           master     #410      +/-   ##
==========================================
+ Coverage   37.51%   38.11%   +0.60%     
==========================================
  Files          12       13       +1     
  Lines        2287     2571     +284     
==========================================
+ Hits          858      980     +122     
- Misses       1358     1514     +156     
- Partials       71       77       +6     

Impacted Files	Coverage Δ
controllers/dpa_controller.go	0.00% <0.00%> (ø)
controllers/monitor.go	41.63% <41.63%> (ø)
controllers/velero.go	38.81% <64.00%> (+1.34%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0adb97b...c99f511. Read the comment docs.

[kaovilai]

/retest

[shawn-hurley]

I worry about adding these permissions to the operator, is there any other way of achieving this?

[shubham-pampattiwar]

@shawn-hurley we need these permissions so that the operator creates the appropriate role/rolebindings needed for the prometheus operator to scrape the metrics from our ns.

[shawn-hurley]

Hmm, isn't that already done by OLM when installing if you have the correct annotation?

[shubham-pampattiwar]

@shawn-hurley PTAL I have removed the prometheus role/rolebinding creation by OADP operator.

[smarterclayton]

Is this cardinality 13 or higher for series count planned to send to telemetry?

[shawn-hurley]

@smarterclayton is the cardinality of 13 or lower for each metric, or in total for all metrics?

[shawn-hurley]

@smarterclayton never mind you said series, not metrics sorry

IIUC this means that that we can only send 13 series to monitoring. The key distinction here is going to be that when a label is added to the data, you increase the cardinality by 1.

[shubham-pampattiwar]

Is this cardinality 13 or higher for series count planned to send to telemetry?

@smarterclayton After re-evaluating our telemetry needs, we have decided to use only two metrics to be ingested by openshift-monitoring: velero_backup_total and velero_restore_total . Both these metrics do not have any kind of label, so I believe the cardinality would be 2.

[dymurray]

/retest

[dymurray]

/retest

[dymurray]

/retest

[openshift-ci]

@shubham-pampattiwar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/operator-e2e	305bb6d	link	true	/test operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.