Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install_suite e2e Refractor #428

Merged
merged 11 commits into from
Nov 4, 2021
Merged

Install_suite e2e Refractor #428

merged 11 commits into from
Nov 4, 2021

Conversation

savitharaghunathan
Copy link
Member

  • Overall refactoring of Install_suite e2e
  • Added more checks to Velero deployment

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2021
@savitharaghunathan savitharaghunathan requested review from eemcmullan and dymurray and removed request for alaypatel07 and JaydipGabani November 1, 2021 21:04
@savitharaghunathan savitharaghunathan changed the title WIP: Installsuite e2e Refractor Install_suite e2e Refractor Nov 2, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 2, 2021
eemcmullan
eemcmullan approved these changes Nov 2, 2021
View reviewed changes
tests/e2e/plugins_helpers.go Show resolved Hide resolved
dymurray
dymurray reviewed Nov 3, 2021
View reviewed changes
Copy link
Member

@dymurray dymurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks GREAT. It's really cool you were able to get so many working entries with this refactor. I had one question about the BeforeEach func, and a couple nitpicks. Other than that LGTM!

tests/e2e/velero_deployment_suite_test.go Outdated Show resolved Hide resolved
tests/e2e/velero_helpers.go Outdated Show resolved Hide resolved
tests/e2e/velero_helpers.go Outdated Show resolved Hide resolved
@dymurray dymurray merged commit 7f01111 into openshift:master Nov 4, 2021
@savitharaghunathan savitharaghunathan deleted the installsuite_e2e branch November 4, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dymurray dymurray dymurray left review comments

@eemcmullan eemcmullan eemcmullan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@savitharaghunathan @dymurray @eemcmullan