-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding profile support for registry #442
Adding profile support for registry #442
Conversation
540f1e6
to
e45dfb6
Compare
Codecov Report
@@ Coverage Diff @@
## master #442 +/- ##
==========================================
+ Coverage 41.48% 41.51% +0.03%
==========================================
Files 9 9
Lines 1849 1869 +20
==========================================
+ Hits 767 776 +9
- Misses 1033 1040 +7
- Partials 49 53 +4
Continue to review full report at Codecov.
|
a281009
to
59b9c0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deepakraj1997 Thank you for the PR. Overall changes look great ! Just added some suggestions.
/retest |
@shubham-pampattiwar thanks for the review. I have made the requested changes. Do review when u have time. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just added a couple of nits. Apart from that LGTM ! Thank you !
Resolves #435