remove default secret volumes when using cloud storage provider #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding back removed tests refactoring so the logic is shared between validation and customization.
shawn-hurley
requested review from
dymurray,
kaovilai and
shubham-pampattiwar
and removed request for
dymurray and
kaovilai
kaovilai
reviewed
Dec 2, 2021
| @@ -611,3 +617,39 @@ func (r *DPAReconciler) getResticResourceReqs(dpa *oadpv1alpha1.DataProtectionAp | |||
|
|
|||
| return ResourcesReqs | |||
| } | |||
|
|
|||
| func (r DPAReconciler) noDefaultCredentials(dpa oadpv1alpha1.DataProtectionApplication) (map[string]bool, bool, error) { | |||
There was a problem hiding this comment.
A function comment on return vals would be nice so you don't have to inspect the function for what is returned.
|
/retest |
1 similar comment
|
/retest |
dymurray
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding back removed tests
refactoring so the logic is shared between validation and customization.
fixes #490