New structural changes to test repo

[nitishSr]

This PR tries to introduce new structure for organising test repo as per below structure -

.
└── oadp-operator/
    └── tests/
        └── e2e/
            ├── templates/
            │   ├── velero_bsl_template.tmpl
            │   └── credentials
            ├── lib/
            │   ├── kube_helpers.go
            │   └── velero_helpers.go
            ├── utils/
            │   └── common.go
              velero_deployment_suite_test.go
              bsl_suite_test.go
              vsl_suite_test.go
              e2e_suite_test.go

[openshift-ci]

Hi @nitishSr. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dymurray]

@nitishSr I like the structural changes, LGTM. Let me know when this is ready for review

[codecov-commenter]

Codecov Report

Merging #531 (5c8dc34) into master (816cb83) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #531   +/-   ##
=======================================
  Coverage   38.32%   38.32%           
=======================================
  Files          13       13           
  Lines        2839     2839           
=======================================
  Hits         1088     1088           
  Misses       1671     1671           
  Partials       80       80           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbab17b...5c8dc34. Read the comment docs.

[dymurray]

/ok-to-test

[nitishSr]

/retest

[nitishSr]

/retest

[openshift-ci]

@nitishSr: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[shubham-pampattiwar]

@nitishSr +1 on the refactoring, just added one question, else LGTM.

[shubham-pampattiwar]

qq: Is the name change intentional or accidental ? The PR description does not mention about e2e_test package #531 (comment)

[nitishSr]

@shubham-pampattiwar yes that is intentional change. Just wanted to be more specific here, to reflect that its a test package (taken as reference from Ginkgo docs)

[kaovilai]

+1
I think exporting functions would allow folks to reuse our e2e functions elsewhere.

[kaovilai]

I think we can remove this? This function doesn't do anything. Can remove later after merge. Thoughts?

[kaovilai]

I see elsewhere we are using os.ReadFile as well which seems to do the same thing.

[kaovilai]

Looks like os.ReadFile is more direct over io/ioutil now... at least from reading https://pkg.go.dev/io/ioutil@go1.17.6#ReadFile

[nitishSr]

@kaovilai I do think the same. I just kept it as it is, considering these changes were made by some earlier PR. I can definitely try to replace it altogether with os.ReadFile() if possible.