Added CSI Example to Docs #554
Conversation
Codecov Report
@@ Coverage Diff @@
## master #554 +/- ##
=======================================
Coverage 38.01% 38.01%
=======================================
Files 13 13
Lines 2825 2825
=======================================
Hits 1074 1074
Misses 1671 1671
Partials 80 80 Continue to review full report at Codecov.
|
|
/retest |
There was a problem hiding this comment.
Thanks for the CSI example @eemcmullan
+1 on the steps and ymls, added a nit/question, rest looks good to me.
docs/examples/csi_example.md
Outdated
|
|
||
| `oc create secret generic cloud-credentials --namespace openshift-adp --from-file cloud=<CREDENTIALS_FILE_PATH>` | ||
|
|
||
| * Make sure your DataProtectionApplication (DPA) CR is similar to below. Note |
There was a problem hiding this comment.
NIT: Just add save this config as config/samples/oadp_v1alpha1_dpa.yaml as you are directly asking the user to create DPA isntance using this file OR just mention that create DPA instance using the above config in Install Velero step.
| provisioner: ebs.csi.aws.com | ||
| parameters: | ||
| type: gp2 | ||
| reclaimPolicy: Delete |
There was a problem hiding this comment.
Shouldn't the reclaimPolicy be set to Retain ?
There was a problem hiding this comment.
@shubham-pampattiwar actually Retain is only required on the VolumeSnapshotClass for snapshots to be retained. We wouldn't want to Retain on StorageClass
https://github.com/vmware-tanzu/velero/blob/main/site/content/docs/main/csi.md#implementation-choices
A new pvc is created and pointed to retained VolumeSnapshot
https://github.com/vmware-tanzu/velero-plugin-for-csi/blob/64cbe394b7bc0bea1a8e88d31452e841e1c673b2/internal/restore/pvc_action.go#L73
There was a problem hiding this comment.
If StorageClass is set to Retain I believe upon restore you would end up with two PVs, the original retained one, and a newly restored one with content from snapshot.
The original PV would be dangling and not connected to anything.. either that or new pv would fail to create due to some kind of conflict which I think velero would be ok with and "skip, already exists"
There was a problem hiding this comment.
Yes what @kaovilai mentioned was my understanding as well. I can verify though.
There was a problem hiding this comment.
"skip, already exists" when restoring PV is undesired because the data could've diverged from initial snapshot and we wanted stuff from snapshot in the PV.
|
/retest |
1 similar comment
|
/retest |
openshift-ci
bot
added
the
needs-rebase
openshift-ci
bot
removed
the
needs-rebase
|
@eemcmullan: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
No description provided.