aws cloudstorage bucket refactor #561
Conversation
Codecov Report
@@ Coverage Diff @@
## master #561 +/- ##
==========================================
- Coverage 38.43% 38.23% -0.21%
==========================================
Files 13 14 +1
Lines 2849 2864 +15
==========================================
Hits 1095 1095
- Misses 1673 1688 +15
Partials 81 81
Continue to review full report at Codecov.
|
kaovilai
force-pushed
the
cloudstorage_azure-aws_refactor
branch
from
89b7e3d
to
0fe0437
Compare
|
+1 |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
I need a recent test result for ci-search. going to kick one job :) |
kaovilai
force-pushed
the
cloudstorage_azure-aws_refactor
branch
from
d1125ff
to
31027fc
Compare
| } | ||
|
|
||
| func (a awsBucketClient) getCredentialFromSecret() (string, error) { | ||
| func getCredentialFromCloudStorageSecret(a client.Client, cloudStorage v1alpha1.CloudStorage) (string, error) { |
There was a problem hiding this comment.
The function is now parameterized so other bucketClient types can access this function by passing its client.Client and CloudStorage
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
| ) | ||
|
|
||
| type CloudStorageSpec struct { | ||
| // Name is the name requested for the bucket | ||
| // Name is the name requested for the bucket (aws, gcp) or container (azure) |
There was a problem hiding this comment.
why is azure container?
There was a problem hiding this comment.
They call it container instead of bucket https://docs.microsoft.com/en-us/cli/azure/storage/container
There was a problem hiding this comment.
Thanks for the knowledge!
|
@kaovilai: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
* aws cloudstorage bucket refactor * remove unused configmap * azure wip wip reset skeleton update wip wip * remove added internal methods from interface, passes more parameters * indent * remove wip azure.go * address openshift#561 (review)
refactoring for adding other clouds.
bits from https://github.com/kaovilai/oadp-operator/tree/cloudstorage_azure refactoring without all the unfinished implementations of azure.
There's a follow-up branch for implementing GCP WIP https://github.com/kaovilai/oadp-operator/tree/cloudstorage_gcp