-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws cloudstorage bucket refactor #561
aws cloudstorage bucket refactor #561
Conversation
Codecov Report
@@ Coverage Diff @@
## master #561 +/- ##
==========================================
- Coverage 38.43% 38.23% -0.21%
==========================================
Files 13 14 +1
Lines 2849 2864 +15
==========================================
Hits 1095 1095
- Misses 1673 1688 +15
Partials 81 81
Continue to review full report at Codecov.
|
89b7e3d
to
0fe0437
Compare
+1 |
I need a recent test result for ci-search. going to kick one job :) |
d1125ff
to
31027fc
Compare
} | ||
|
||
func (a awsBucketClient) getCredentialFromSecret() (string, error) { | ||
func getCredentialFromCloudStorageSecret(a client.Client, cloudStorage v1alpha1.CloudStorage) (string, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function is now parameterized so other bucketClient types can access this function by passing its client.Client
and CloudStorage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, please look at my comment about panicking... if you agree I say just make that change and we'll be good to ack/merge
) | ||
|
||
type CloudStorageSpec struct { | ||
// Name is the name requested for the bucket | ||
// Name is the name requested for the bucket (aws, gcp) or container (azure) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is azure container?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They call it container instead of bucket https://docs.microsoft.com/en-us/cli/azure/storage/container
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the knowledge!
@kaovilai: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
* aws cloudstorage bucket refactor * remove unused configmap * azure wip wip reset skeleton update wip wip * remove added internal methods from interface, passes more parameters * indent * remove wip azure.go * address openshift#561 (review)
refactoring for adding other clouds.
bits from https://github.com/kaovilai/oadp-operator/tree/cloudstorage_azure refactoring without all the unfinished implementations of azure.
There's a follow-up branch for implementing GCP WIP https://github.com/kaovilai/oadp-operator/tree/cloudstorage_gcp