Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Velero metrics recording rule #579

Conversation

shubham-pampattiwar
Copy link
Member

This PR adds a PrometheusRule which removes the instance label from the metrics and restricts the cardinality.

@codecov-commenter
Copy link

Codecov Report

Merging #579 (f9d6026) into master (572a5ff) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #579   +/-   ##
=======================================
  Coverage   37.60%   37.60%           
=======================================
  Files          14       14           
  Lines        2917     2917           
=======================================
  Hits         1097     1097           
  Misses       1737     1737           
  Partials       83       83           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 572a5ff...f9d6026. Read the comment docs.

@openshift-ci
Copy link

openshift-ci bot commented Feb 26, 2022

@shubham-pampattiwar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@weshayutin
Copy link
Contributor

+1

@simonpasquier
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. operator-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants