-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add status descriptors to CSV #580
Add status descriptors to CSV #580
Conversation
NICE! operator-sdk scorecard bundle --selector=test=olm-status-descriptors-test --kubeconfig /home/whayutin/.agnosticd/wdh0211pelorusshared/ocp4-cluster_wdh0211pelorusshared_kubeconfig -n openshift-adp &> /tmp/oadp_head.txt change branch... operator-sdk scorecard bundle --selector=test=olm-status-descriptors-test --kubeconfig /home/whayutin/.agnosticd/wdh0211pelorusshared/ocp4-cluster_wdh0211pelorusshared_kubeconfig -n openshift-adp &> /tmp/oadp_580.txt [whayutin@thinkdoe oadp-operator]$ git diff /tmp/oadp_head.txt /tmp/oadp_580.txt
+2000 |
config/manifests/bases/oadp-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
…nto status-descriptors
…e bundle`, `go mod tidy` - Fix `operator-sdk bundle validate ./bundle` `ERRO[0000] Error: Value openshift-adp-controller-manager: invalid service account found in bundle. sa name cannot match service account defined for deployment spec in CSV` - Moved PrometheusRule to config/prometheus, include prometheus in kustomize - `go mod tidy`
Please review minor changes suggested in eemcmullan#1 |
Edited oadp_types.go, moved `PrometheusRule` to `config/..`, ran `mak…
Codecov Report
@@ Coverage Diff @@
## master #580 +/- ##
=======================================
Coverage 37.60% 37.60%
=======================================
Files 14 14
Lines 2917 2917
=======================================
Hits 1097 1097
Misses 1737 1737
Partials 83 83 Continue to review full report at Codecov.
|
@eemcmullan: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
operator-sdk scorecard bundle --selector=test=olm-status-descriptors-test
now passes.