Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status descriptors to CSV #580

Merged
merged 6 commits into from
Mar 3, 2022

Conversation

eemcmullan
Copy link
Contributor

operator-sdk scorecard bundle --selector=test=olm-status-descriptors-test now passes.

@weshayutin
Copy link
Contributor

weshayutin commented Feb 28, 2022

NICE!

operator-sdk scorecard bundle --selector=test=olm-status-descriptors-test --kubeconfig /home/whayutin/.agnosticd/wdh0211pelorusshared/ocp4-cluster_wdh0211pelorusshared_kubeconfig -n openshift-adp &> /tmp/oadp_head.txt

change branch...

operator-sdk scorecard bundle --selector=test=olm-status-descriptors-test --kubeconfig /home/whayutin/.agnosticd/wdh0211pelorusshared/ocp4-cluster_wdh0211pelorusshared_kubeconfig -n openshift-adp &> /tmp/oadp_580.txt

[whayutin@thinkdoe oadp-operator]$ git diff /tmp/oadp_head.txt /tmp/oadp_580.txt

diff --git a/tmp/oadp_head.txt b/tmp/oadp_580.txt
index 6fbf2df..c6522f8 100644
--- a/tmp/oadp_head.txt
+++ b/tmp/oadp_580.txt
@@ -6,21 +6,8 @@ Labels:
        "test":"olm-status-descriptors-test"
 Results:
        Name: olm-status-descriptors
-       State: fail
+       State: pass
 
-       Errors:
-               dataprotectionapplications.oadp.openshift.io does not have a status descriptor
-               backups.velero.io does not have a status descriptor
-               backupstoragelocations.velero.io does not have a status descriptor
-               deletebackuprequests.velero.io does not have a status descriptor
-               downloadrequests.velero.io does not have a status descriptor
-               podvolumebackups.velero.io does not have a status descriptor
-               podvolumerestores.velero.io does not have a status descriptor
-               resticrepositories.velero.io does not have a status descriptor
-               restores.velero.io does not have a status descriptor
-               schedules.velero.io does not have a status descriptor
-               serverstatusrequests.velero.io does not have a status descriptor
-               volumesnapshotlocations.velero.io does not have a status descriptor
        Log:
                Loaded ClusterServiceVersion: oadp-operator.v99.0.0
                Loaded 12 Custom Resources from alm-examples

+2000

eemcmullan and others added 3 commits March 3, 2022 09:39
…e bundle`, `go mod tidy`

- Fix `operator-sdk bundle validate ./bundle`
   `ERRO[0000] Error: Value openshift-adp-controller-manager: invalid service account found in bundle. sa name cannot match service account defined for deployment spec in CSV`
- Moved PrometheusRule to config/prometheus, include prometheus in kustomize
- `go mod tidy`
@kaovilai
Copy link
Member

kaovilai commented Mar 3, 2022

Please review minor changes suggested in eemcmullan#1

Edited oadp_types.go, moved `PrometheusRule` to `config/..`, ran `mak…
@codecov-commenter
Copy link

Codecov Report

Merging #580 (1bd97fb) into master (572a5ff) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #580   +/-   ##
=======================================
  Coverage   37.60%   37.60%           
=======================================
  Files          14       14           
  Lines        2917     2917           
=======================================
  Hits         1097     1097           
  Misses       1737     1737           
  Partials       83       83           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e661809...1bd97fb. Read the comment docs.

@openshift-ci
Copy link

openshift-ci bot commented Mar 3, 2022

@eemcmullan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@shubham-pampattiwar shubham-pampattiwar merged commit b3e6819 into openshift:master Mar 3, 2022
@eemcmullan eemcmullan deleted the status-descriptors branch August 30, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants