Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile refactor deploy-tmp to velero-role-tmp expose apply-velerosa-role #581

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Mar 1, 2022

Helps create velero SA roles when running operator controller-manager locally in IDE so velero and restic pods have permissions.
Normally OLM would handle this task when installing operator from OperatorHub.

Breaks out SA role creation code away from make deploy so it can be used separately.

@kaovilai
Copy link
Member Author

kaovilai commented Mar 1, 2022

/retest-required

@openshift-ci
Copy link

openshift-ci bot commented Mar 2, 2022

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@shubham-pampattiwar shubham-pampattiwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shubham-pampattiwar shubham-pampattiwar merged commit c5293b1 into openshift:master Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants