-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OADP-450] Reduce "perform updated on X ..." reconciler logs #584
[OADP-450] Reduce "perform updated on X ..." reconciler logs #584
Conversation
2163a0e
to
ceb92d1
Compare
ceb92d1
to
45bd6fc
Compare
Codecov Report
@@ Coverage Diff @@
## master #584 +/- ##
==========================================
- Coverage 37.60% 37.49% -0.12%
==========================================
Files 14 14
Lines 2917 2915 -2
==========================================
- Hits 1097 1093 -4
- Misses 1737 1739 +2
Partials 83 83
Continue to review full report at Codecov.
|
2ae3a95
to
0b6df3a
Compare
0b6df3a
to
50fa01a
Compare
/retest |
Maybe copy typemeta instead of ignoring in test. |
@kaovilai: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
* Eliminate "perform updated on dpa metrics service" from logs * restic reconcile log reduction * reduce velero deployment reconcile logs * setDsDefaults is not needed * Revert "Eliminate "perform updated on dpa metrics service" from logs" This reverts commit 45bd6fc. * defaultMode no longer needed * remove prevDs * No need to save deploymentName and ownerRefs * rm typemeta ignores
* Eliminate "perform updated on dpa metrics service" from logs * restic reconcile log reduction * reduce velero deployment reconcile logs * setDsDefaults is not needed * Revert "Eliminate "perform updated on dpa metrics service" from logs" This reverts commit 45bd6fc. * defaultMode no longer needed * remove prevDs * No need to save deploymentName and ownerRefs * rm typemeta ignores
/cherry-pick oadp-1.0 |
@kaovilai: #584 failed to apply on top of branch "oadp-1.0":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reduce 🙈 update events and eliminate ObjectMeta update race 🏎 conditions for velero deployment and restic daemonset.
Now results from CreateOrUpdate are either created, or unchanged, update events are minimal.
No longer producing race condition update events thus reduces 99% of logs currently printed from these reconcilers.