Add kubevirt to pluginSpecificFields, rm unused var #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaovilai
force-pushed
the
kubevirtPluginSpecificFields
branch
from
c475981
to
6fddf61
Compare
|
@kaovilai Can you please add a unit test for this ? |
kaovilai
force-pushed
the
kubevirtPluginSpecificFields
branch
from
6fddf61
to
3c317a3
Compare
kaovilai
force-pushed
the
kubevirtPluginSpecificFields
branch
from
3c317a3
to
b57f3d5
Compare
@shubham-pampattiwar done in |
shubham-pampattiwar
approved these changes
Mar 8, 2022
|
@kaovilai: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
dymurray
pushed a commit
that referenced
this pull request
Mar 18, 2022
* Add kubevirt to pluginSpecificFields, rm unused var * also update docs when adding new plugin (cherry picked from commit 25f2f0b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes OADP-139
Related to #563 #583