Adding Multi Cloud Testing Docs #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepakraj1997
requested review from
weshayutin,
dymurray,
hhpatel14 and
mperetzred
kaovilai
approved these changes
Mar 18, 2022
weshayutin
reviewed
Mar 18, 2022
| The Test Suite now takes different env variables related to the cloud as flags and create the VSLs based on that cloud provider. Validating the backup / restore test cases on the same. | ||
|
|
||
| ### How multiple profiles are enabled to support Backup / Restore. | ||
| In ideal cases, both the credentials / profile for BSL and VSL would be the same and usually we dont mention the separate creds for them, but this is different in CI environments. In CI environment, the cluster is provisioned in CI Cloud / Cluster which we dont have access to, hence supporting volume backup using our credentials which is mounted in CI environment is not a valid option. Hence we are using different methods to support these. |
There was a problem hiding this comment.
s/In CI environment/In a CI environment/
s//In CI environment/In the prow CI environment/
There was a problem hiding this comment.
nit.. fix.." the cluster is provisioned in CI Cloud / Cluster"
There was a problem hiding this comment.
nit.. mounted in CI environment
weshayutin
reviewed
Mar 18, 2022
|
|
||
| #### AWS Multi Profile Support | ||
|
|
||
| The CI Cloud cred is present at this location in CI Environment, |
There was a problem hiding this comment.
nit.. Cred or cred ? How about credentials?
weshayutin
reviewed
Mar 18, 2022
|
|
||
| #### GCP | ||
|
|
||
| The CI Cloud cred is present at this location in CI Environment, |
weshayutin
reviewed
Mar 18, 2022
| Here since they are two different credentials and not profiles, we are using the concept of credentialsFile in BSL config ref: https://github.com/vmware-tanzu/velero/issues/3430. | ||
|
|
||
| We are also mounting credentials here: | ||
| https://github.com/deepakraj1997/oadp-operator/blob/multi-cloud-e2e-master-rebase/pkg/credentials/credentials.go#L48 |
weshayutin
reviewed
Mar 18, 2022
|
seems like "VSL_REGION - the region" etc.. misrendered |
|
Just copied from hackmd but its rendering a bit different in GitHub. Fixed review comments. |
dymurray
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.