-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix access key value containing =
edge case
#603
Conversation
=
edge case=
edge case
Codecov Report
@@ Coverage Diff @@
## master #603 +/- ##
==========================================
+ Coverage 37.21% 37.27% +0.06%
==========================================
Files 14 14
Lines 2937 2940 +3
==========================================
+ Hits 1093 1096 +3
Misses 1761 1761
Partials 83 83
Continue to review full report at Codecov.
|
go get github.com/onsi/ginkgo/ginkgo | ||
go get github.com/onsi/ginkgo/v2/ginkgo | ||
go get github.com/onsi/gomega/... | ||
go get -d github.com/onsi/ginkgo/ginkgo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix deprecation warning
/retest |
/test operator-e2e-azure |
@kaovilai: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM at a glance.
@kaovilai: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. Thanks @kaovilai
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
OADP-378 cherry-pick 1.0 Fix access key value containing `=` edge case (openshift#603) * Fix secret `=` edge case * revert `-d` for go-get-tool * remove `=` from azure match key * add unit test case with `=` in secretkey value * allow quotes and spaces + tests * Remove space via replaceAll instead of trim
OADP-378 cherry-pick 1.0 Fix access key value containing `=` edge case (#603) * Fix secret `=` edge case * revert `-d` for go-get-tool * remove `=` from azure match key * add unit test case with `=` in secretkey value * allow quotes and spaces + tests * Remove space via replaceAll instead of trim
Close #529
OADP-378
PR CatalogSource