Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix access key value containing = edge case #603

Merged
merged 6 commits into from
Mar 28, 2022
Merged

Fix access key value containing = edge case #603

merged 6 commits into from
Mar 28, 2022

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Mar 19, 2022 •
edited

Close #529
OADP-378

PR CatalogSource

apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
  name: oadp-secretparsing
  namespace: openshift-marketplace
spec:
  sourceType: grpc
  image: ghcr.io/kaovilai/oadp-operator-catalog:secretparsing
  displayName: Tiger's OADP SecretParsing
  publisher: Tiger Kaovilai
  updateStrategy:
    registryPoll:
      interval: 10m

@kaovilai kaovilai changed the title Fix secret = edge case Fix access key value containing = edge case Mar 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2022 •
edited

Codecov Report

Merging #603 (0f6c142) into master (a4ede2a) will increase coverage by 0.06%.
The diff coverage is 48.48%.

@@            Coverage Diff             @@
##           master     #603      +/-   ##
==========================================
+ Coverage   37.21%   37.27%   +0.06%     
==========================================
  Files          14       14              
  Lines        2937     2940       +3     
==========================================
+ Hits         1093     1096       +3     
  Misses       1761     1761              
  Partials       83       83
Impacted Files Coverage Δ
controllers/bucket_controller.go 0.00% <0.00%> (ø)
controllers/registry.go 40.89% <51.61%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4ede2a...0f6c142. Read the comment docs.

kaovilai
kaovilai commented Mar 19, 2022
View reviewed changes
Makefile
go get github.com/onsi/ginkgo/ginkgo
go get github.com/onsi/ginkgo/v2/ginkgo
go get github.com/onsi/gomega/...
go get -d github.com/onsi/ginkgo/ginkgo
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix deprecation warning

@kaovilai
Copy link
Member Author

/retest

@kaovilai
Copy link
Member Author

/test operator-e2e-azure

@openshift-ci
Copy link

openshift-ci bot commented Mar 20, 2022

@kaovilai: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test 4.7-ci-index
  • /test 4.7-images
  • /test 4.7-operator-e2e
  • /test 4.7-operator-unit-test
  • /test 4.8-ci-index
  • /test 4.8-images
  • /test 4.8-operator-e2e
  • /test 4.8-operator-unit-test
  • /test 4.9-ci-index
  • /test 4.9-images
  • /test 4.9-operator-e2e
  • /test 4.9-operator-unit-test

Use /test all to run all jobs.

In response to this:

/test operator-e2e-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kaovilai kaovilai mentioned this pull request Mar 21, 2022
Closed
dymurray
dymurray approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@dymurray dymurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM at a glance.

@openshift-ci
Copy link

openshift-ci bot commented Mar 23, 2022

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

savitharaghunathan
savitharaghunathan reviewed Mar 28, 2022
View reviewed changes
Copy link
Member

@savitharaghunathan savitharaghunathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Thanks @kaovilai

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2022
shubham-pampattiwar
shubham-pampattiwar approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@shubham-pampattiwar shubham-pampattiwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@shubham-pampattiwar shubham-pampattiwar merged commit aa8be92 into openshift:master Mar 28, 2022
kaovilai added a commit to kaovilai/oadp-operator that referenced this pull request May 6, 2022
@kaovilai
OADP-378 cherry-pick 1.0
6e41423 
OADP-378 cherry-pick 1.0

Fix access key value containing `=` edge case (openshift#603)

* Fix secret `=` edge case

* revert `-d` for go-get-tool

* remove `=` from azure match key

* add unit test case with `=` in secretkey value

* allow quotes and spaces + tests

* Remove space via replaceAll instead of trim
dymurray pushed a commit that referenced this pull request May 6, 2022
@kaovilai
OADP-378 cherry-pick 1.0 (#672)
6dc6271 
OADP-378 cherry-pick 1.0

Fix access key value containing `=` edge case (#603)

* Fix secret `=` edge case

* revert `-d` for go-get-tool

* remove `=` from azure match key

* add unit test case with `=` in secretkey value

* allow quotes and spaces + tests

* Remove space via replaceAll instead of trim
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savitharaghunathan savitharaghunathan savitharaghunathan left review comments

@dymurray dymurray dymurray approved these changes

@shubham-pampattiwar shubham-pampattiwar shubham-pampattiwar approved these changes

@sseago sseago Awaiting requested review from sseago

Assignees

@savitharaghunathan savitharaghunathan

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: error: Could not parse secret for AWS Secret key
5 participants
@kaovilai @codecov-commenter @savitharaghunathan @dymurray @shubham-pampattiwar