-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OADP-339: Introduce stable-1.0 channel #606
OADP-339: Introduce stable-1.0 channel #606
Conversation
It looks like a lot changes caused by line-wrapping & indenting performed by operator-sdk were introduced. |
@kaovilai , please provide input on
Thanks! |
yq usage is a trick workaround for operator-sdk to add velero service account into CSV in the same namespace as operator controller manager's deployment. Having velero SA defined outside of CSV will result in velero SA ending up in potentially different namespace to operator controller manager and resulting velero deployments.. rendering SA useless. |
Thanks, @kaovilai , for the assistance and explanations!
After sorting out the |
On that note.. I think operator-sdk may have fixed the issue. |
@shawn-hurley , particularly interested in your review/ack to ensure we're capturing things as expected. Thanks! cc: @weshayutin |
LABEL operators.operatorframework.io.metrics.builder=operator-sdk-v1.14.0 | ||
LABEL operators.operatorframework.io.bundle.channels.v1=stable,stable-1.0 | ||
LABEL operators.operatorframework.io.bundle.channel.default.v1=stable-1.0 | ||
LABEL operators.operatorframework.io.metrics.builder=operator-sdk-v1.18.0+git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately I don't know of a way to fix the git
suffix, this happens with everyones installs on linux. So it's weird but fine by me. If you wanted ot manually remove it that works too.
No description provided.