Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OADP-339: Introduce stable-1.0 channel #606

Merged
merged 2 commits into from
Mar 23, 2022

Conversation

rayfordj
Copy link
Contributor

No description provided.

@rayfordj
Copy link
Contributor Author

rayfordj commented Mar 21, 2022

It looks like a lot changes caused by line-wrapping & indenting performed by operator-sdk were introduced.

@rayfordj
Copy link
Contributor Author

@kaovilai , please provide input on make bundle's usage of yq because it was failing for me. I'm not confident in what its expected to be doing.

yq: error: argument files: can't open 'del(.spec.install.spec.deployments.1)': [Errno 2] No such file or directory: 'del(.spec.install.spec.deployments.1)'

Thanks!

@kaovilai
Copy link
Member

kaovilai commented Mar 21, 2022

yq usage is a trick workaround for operator-sdk to add velero service account into CSV in the same namespace as operator controller manager's deployment.
https://coreos.slack.com/archives/C0144ECKUJ0/p1638394991106700?thread_ts=1638283821.071800&cid=C0144ECKUJ0

Having velero SA defined outside of CSV will result in velero SA ending up in potentially different namespace to operator controller manager and resulting velero deployments.. rendering SA useless.

Thanks, @kaovilai , for the assistance and explanations!
@rayfordj
Copy link
Contributor Author

It looks like a lot changes caused by line-wrapping & indenting performed by operator-sdk were introduced.

After sorting out the yq failing, the changes are now more representative of what's expected.

@kaovilai
Copy link
Member

On that note.. I think operator-sdk may have fixed the issue.
operator-framework/operator-sdk#4751

@rayfordj
Copy link
Contributor Author

@shawn-hurley , particularly interested in your review/ack to ensure we're capturing things as expected. Thanks!

cc: @weshayutin

LABEL operators.operatorframework.io.metrics.builder=operator-sdk-v1.14.0
LABEL operators.operatorframework.io.bundle.channels.v1=stable,stable-1.0
LABEL operators.operatorframework.io.bundle.channel.default.v1=stable-1.0
LABEL operators.operatorframework.io.metrics.builder=operator-sdk-v1.18.0+git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I don't know of a way to fix the git suffix, this happens with everyones installs on linux. So it's weird but fine by me. If you wanted ot manually remove it that works too.

@rayfordj rayfordj merged commit 8e8bf82 into openshift:oadp-1.0 Mar 23, 2022
@rayfordj rayfordj deleted the MIG-339_add_stable-1.0_channel branch March 23, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants