Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upstream kubevirt tag in manager deployment env, preserve #611 changes in config #615

Merged
merged 2 commits into from
Apr 8, 2022

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Mar 25, 2022

preserve OADP-380 in config

@kaovilai
Copy link
Member Author

/retest

3 similar comments
@kaovilai
Copy link
Member Author

/retest

@kaovilai
Copy link
Member Author

/retest

@kaovilai
Copy link
Member Author

/retest

@@ -14,6 +14,8 @@ metadata:
operatorframework.io/cluster-monitoring: "true"
operatorframework.io/suggested-namespace: openshift-adp
operators.openshift.io/infrastructure-features: '["Disconnected"]'
operators.openshift.io/valid-subscription: '["OpenShift Container Platform", "OpenShift
Platform Plus"]'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why new line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because

operator-sdk generate kustomize manifests -q

automatically caused it to truncate the line.

@kaovilai kaovilai changed the title Preserve #611 bundle changes in config manifests Update upstream kubevirt tag, preserve #611 changes in config Apr 7, 2022
@kaovilai kaovilai changed the title Update upstream kubevirt tag, preserve #611 changes in config Update upstream kubevirt tag in manager deployment env, preserve #611 changes in config Apr 7, 2022
Copy link
Contributor

@rayfordj rayfordj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 7, 2022

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kaovilai kaovilai merged commit 1d64f78 into openshift:master Apr 8, 2022
kaovilai added a commit to kaovilai/oadp-operator that referenced this pull request May 6, 2022
…shift#611 changes in config (openshift#615)

* Preserve openshift#611 bundle changes in config manifests

* prefix `v` to kubevirt tag
kaovilai added a commit to kaovilai/oadp-operator that referenced this pull request May 6, 2022
…shift#611 changes in config (openshift#615)

* Preserve openshift#611 bundle changes in config manifests

* prefix `v` to kubevirt tag
dymurray pushed a commit that referenced this pull request May 9, 2022
…changes in config (#615) (#675)

* Preserve #611 bundle changes in config manifests

* prefix `v` to kubevirt tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants