-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update upstream kubevirt tag in manager deployment env, preserve #611 changes in config #615
Conversation
/retest |
3 similar comments
/retest |
/retest |
/retest |
@@ -14,6 +14,8 @@ metadata: | |||
operatorframework.io/cluster-monitoring: "true" | |||
operatorframework.io/suggested-namespace: openshift-adp | |||
operators.openshift.io/infrastructure-features: '["Disconnected"]' | |||
operators.openshift.io/valid-subscription: '["OpenShift Container Platform", "OpenShift | |||
Platform Plus"]' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why new line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because
Line 262 in 726af63
operator-sdk generate kustomize manifests -q |
automatically caused it to truncate the line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@kaovilai: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
…shift#611 changes in config (openshift#615) * Preserve openshift#611 bundle changes in config manifests * prefix `v` to kubevirt tag
…shift#611 changes in config (openshift#615) * Preserve openshift#611 bundle changes in config manifests * prefix `v` to kubevirt tag
preserve OADP-380 in config