Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update docs/examples, use ci templates and mysql #627

Merged
merged 2 commits into from
Apr 8, 2022
Merged

update docs/examples, use ci templates and mysql #627

merged 2 commits into from
Apr 8, 2022

Conversation

weshayutin
Copy link
Contributor

  • Previously we had duplicate templates for mssql
  • Templates used in docs/examples should be part of
    regular ci to ensure they always work for the community
    • using softlinks from tests/e2e to docs/examples/
  • update the docs s/mssql/mysql

Closes-Issue: #622

@weshayutin
update docs/examples, use ci templates and mysql
45c6cc4 
* Previously we had duplicate templates for mssql
* Templates used in docs/examples should be part of
regular ci to ensure they always work for the community
  * using softlinks from tests/e2e to docs/examples/
* update the docs s/mssql/mysql

Closes-Issue: #622
@openshift-ci openshift-ci bot requested review from kaovilai and rayfordj April 7, 2022 14:34
@weshayutin
Copy link
Contributor Author

/retest

@weshayutin
Copy link
Contributor Author

@deepak1725 @kaovilai @hhpatel14 @EmilyM1 FYI.. I have updated or changed some of your doc or templates. Please review. Thank you!

kaovilai
kaovilai reviewed Apr 7, 2022
View reviewed changes
docs/examples/manifests/mysql Outdated
@@ -0,0 +1 @@
/home/whayutin/OPENSHIFT/git/OADP/oadp-operator/tests/e2e/sample-applications/mysql-persistent/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crap.. soft links were not relative

kaovilai
kaovilai reviewed Apr 7, 2022
View reviewed changes
docs/examples/manifests/nginx Outdated
@@ -0,0 +1 @@
/home/whayutin/OPENSHIFT/git/OADP/oadp-operator/tests/e2e/sample-applications/nginx/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are these for?

@deepak1725
Copy link

@deepak1725 @kaovilai @hhpatel14 @EmilyM1 FYI.. I have updated or changed some of your doc or templates. Please review. Thank you!

I am not sure why I am tagged here.

@weshayutin
Copy link
Contributor Author

sorry.. I meant to tag @deepakraj1997

@kaovilai
Copy link
Member

kaovilai commented Apr 7, 2022

I was like damn.. that new profile pic.

@openshift-ci
Copy link

openshift-ci bot commented Apr 7, 2022

@weshayutin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hhpatel14
Copy link
Contributor

LGTM

@weshayutin weshayutin merged commit 961e54d into openshift:master Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaovilai kaovilai kaovilai left review comments

@dymurray dymurray dymurray approved these changes

@rayfordj rayfordj Awaiting requested review from rayfordj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@weshayutin @deepak1725 @kaovilai @hhpatel14 @dymurray