Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode Debugging launch template. e2e accept environment flags. #639

Merged
merged 4 commits into from
May 3, 2022

Conversation

kaovilai
Copy link
Member

No description provided.

@kaovilai
Copy link
Member Author

/retest

1 similar comment
@kaovilai
Copy link
Member Author

/retest

@kaovilai kaovilai changed the title IDE launch template. e2e flags from environment. VSCode Debugging launch template. e2e accept environment flags. Apr 14, 2022
"program": "${workspaceRoot}/tests/e2e/e2e_suite_test.go",
"env": {
// "KUBECONFIG": "/path/to/.kube/config",
"KUBERNETES_MASTER": "http://localhost:8080",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

localhost:8080 4reelz?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the default. Not defining it is also fine.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your kubeconfig takes care of what cluster it talks to.

@kaovilai
Copy link
Member Author

Looks like openshift_ci need to be set to true for CI to create corresponding secrets required for e2e to work now.

@kaovilai
Copy link
Member Author

/retest

2 similar comments
@kaovilai
Copy link
Member Author

/retest

@kaovilai
Copy link
Member Author

kaovilai commented May 2, 2022

/retest

@openshift-ci
Copy link

openshift-ci bot commented May 2, 2022

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kaovilai kaovilai merged commit fc044bb into openshift:master May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants