Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e retries CreateOrUpdate on DPA to resolve "... please apply your changes to the latest version ..." #653

Conversation

kaovilai
Copy link
Member

Avoid problem in CI runs like this one

I0428 22:42:31.188622    7196 request.go:665] Waited for 1.033692523s due to client-side throttling, not priority and fairness, request: GET:https://api.ci-op-mcwigx1i-4818d.XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX:6443/apis/security.internal.openshift.io/v1?timeout=32s
2022/04/28 22:42:32 Waiting for velero pod to be running
2022/04/28 22:42:35 Checking for bsl spec
2022/04/28 22:42:35 Waiting for restic daemonset to be deleted
2022/04/28 22:42:35 Checking if Restic daemonset has been deleted...
2022/04/28 22:42:35 Waiting for velero deployment to have expected plugins
2022/04/28 22:42:35 Checking for default plugins
2022/04/28 22:42:35 Waiting for velero deployment to have expected custom plugins
2022/04/28 22:42:35 Waiting for registry pods to be running
2022/04/28 22:42:35 Checking for available registry deployments
• [SLOW TEST] [5.379 seconds]
Configuration testing for DPA Custom Resource Updating custom resource with new configuration Default velero CR with restic disabled
/go/src/github.com/openshift/oadp-operator/tests/e2e/dpa_deployment_suite_test.go:220
------------------------------
2022/04/28 22:42:38 Running must gather for failed test - Adding CSI plugin
• [FAILED] [2.613 seconds]
Configuration testing for DPA Custom Resource
/go/src/github.com/openshift/oadp-operator/tests/e2e/dpa_deployment_suite_test.go:20
  Updating custom resource with new configuration
  /go/src/github.com/openshift/oadp-operator/tests/e2e/dpa_deployment_suite_test.go:488
    [It] Adding CSI plugin
    /go/src/github.com/openshift/oadp-operator/tests/e2e/dpa_deployment_suite_test.go:252
push_pin
  Unexpected error:
      <*errors.StatusError | 0xc0004ffc20>: {
          ErrStatus: {
              TypeMeta: {Kind: "", APIVersion: ""},
              ListMeta: {
                  SelfLink: "",
                  ResourceVersion: "",
                  Continue: "",
                  RemainingItemCount: nil,
              },
              Status: "Failure",
              Message: "Operation cannot be fulfilled on dataprotectionapplications.oadp.openshift.io \"ts-velero-sample\": the object has been modified; please apply your changes to the latest version and try again",
              Reason: "Conflict",
              Details: {
                  Name: "ts-velero-sample",
                  Group: "oadp.openshift.io",
                  Kind: "dataprotectionapplications",
                  UID: "",
                  Causes: nil,
                  RetryAfterSeconds: 0,
              },
              Code: 409,
          },
      }
      Operation cannot be fulfilled on dataprotectionapplications.oadp.openshift.io "ts-velero-sample": the object has been modified; please apply your changes to the latest version and try again
  occurred
  In [It] at: /go/src/github.com/openshift/oadp-operator/tests/e2e/dpa_deployment_suite_test.go:527

@kaovilai kaovilai force-pushed the e2eCreateOrUpdateDpaAvoidOutdatedObjectMeta branch from 9f99ad2 to a78d8f4 Compare April 29, 2022 07:12
@kaovilai kaovilai changed the title Avoid CreateOrUpdate DPA "object has been modified; please apply your changes to the latest version and try again" e2e retries CreateOrUpdate on DPA to resolve "... please apply your changes to the latest version ..." Apr 29, 2022
@kaovilai
Copy link
Member Author

/retest

sseago
sseago previously requested changes Apr 29, 2022
tests/e2e/lib/dpa_helpers.go Outdated Show resolved Hide resolved
@kaovilai
Copy link
Member Author

/retest

1 similar comment
@kaovilai
Copy link
Member Author

/retest

@kaovilai
Copy link
Member Author

/retest

2 similar comments
@kaovilai
Copy link
Member Author

/retest

@kaovilai
Copy link
Member Author

kaovilai commented May 2, 2022

/retest

@openshift-ci
Copy link

openshift-ci bot commented May 2, 2022

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@deepakraj1997 deepakraj1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants