Makefile CLUSTER_TYPE auto discovery #664
Conversation
kaovilai
changed the title
kaovilai
requested review from
deepakraj1997
and removed request for
rayfordj and
pranavgaikwad
Makefile
Outdated
| @@ -1,5 +1,5 @@ | |||
| OADP_TEST_NAMESPACE ?= openshift-adp | |||
| CLUSTER_TYPE ?= aws | |||
| CLUSTER_TYPE ?= $(shell oc get infrastructures cluster -o jsonpath='{.status.platform}' | awk '{print tolower($0)}') | |||
There was a problem hiding this comment.
Just a heads up here, OC client, if you look this, you can see that OC CLI has been exposed at this DIR, its working probably cause this directory is in PATH, which wasnt the case when I added the CLI in the release repository. In future if this happens to fail due to client not being found, we can use this directly from the path.
There was a problem hiding this comment.
@deepakraj1997 I don't know which line you were referencing. The link didn't contain line number
There was a problem hiding this comment.
Nvm.. the link contained line number.. but it just wasn't part of this PR's diff and the link didn't work.
There was a problem hiding this comment.
Oop, sorry, looks like you got it resolved. Thanks!
|
@kaovilai: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
No description provided.