Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy-olm make target uses tmp to avoid modifying repo #669

Merged
merged 4 commits into from
May 9, 2022

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented May 6, 2022

In addition to no longer modifying repo while using deploy-olm, you can checkout and work on a different branch while deploy-olm is running from /tmp directory.

@kaovilai
Copy link
Member Author

kaovilai commented May 6, 2022

nonlinux issue in podman 4.0.2 that only occurs while building in /tmp
resolved by going to podman 4.0.3

podman --log-level debug  build -f bundle.Dockerfile -t ttl.sh/oadp-operator-bundle-7cb60cc:1h . --logfile ~/podmanBuildLog
INFO[0000] podman filtering at log level debug          
DEBU[0000] Called build.PersistentPreRunE(podman --log-level debug build -f bundle.Dockerfile -t ttl.sh/oadp-operator-bundle-7cb60cc:1h . --logfile /Users/tiger/podmanBuildLog) 
DEBU[0000] SSH Ident Key "/Users/tiger/.ssh/podman-machine-default" SHA256:aEWXfVij4VJIp+tKa25i8oq34kYf0kPMW5o5+Zi0in0 ssh-ed25519 
DEBU[0000] Found SSH_AUTH_SOCK "/private/tmp/com.apple.launchd.TBxZWLr53z/Listeners", ssh-agent signer(s) enabled 
DEBU[0000] DoRequest Method: GET URI: http://d/v4.0.2/libpod/_ping 
Error: stat /var/tmp/libpod_builder4065820247/build/tmp/oadp-deploy-olm/bundle.Dockerfile: no such file or directory

@kaovilai
Copy link
Member Author

kaovilai commented May 6, 2022

/retest

@dymurray
Copy link
Member

dymurray commented May 6, 2022

Looks good to me, consider using mktemp too to get a new name every time

@kaovilai

This comment was marked as resolved.

@openshift-ci
Copy link

openshift-ci bot commented May 7, 2022

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dymurray dymurray merged commit ef926a8 into openshift:master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants