OADP 486 - Update velero service account permissions #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/approve |
|
If we are removing velero-privileged here maybe remove the SCC from reconciler in go too? |
|
I didn't even realize we were still creating that SCC. I don't want to introduce too much churn into 1.0.3.... I will keep that for now |
kaovilai
approved these changes
May 9, 2022
|
/retest |
|
@dymurray: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
dymurray
added a commit
to dymurray/oadp-operator
that referenced
this pull request
May 9, 2022
* OADP 486 - Update velero service account permissions * Add back velero-privileged (cherry picked from commit 3612b14)
kaovilai
pushed a commit
that referenced
this pull request
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OADP-486